[Windows] Always open similar files check mark is not displayed in about:downloads
Categories
(Firefox :: Downloads Panel, defect, P3)
Tracking
()
People
(Reporter: atrif, Assigned: emilio)
References
(Blocks 1 open bug)
Details
Attachments
(3 files)
checkmark_about_downloads.gif
Found in
- 106.0b4 (20220925185751)
Affected versions
- 106.0b4 (20220925185751)
- 107.0a1 (20220925213821)
- 105.0(20220915150737)
- 102.3.0esr (20220912135840)
Tested platforms
-
Affected platforms: Windows 7x64, Ubuntu 20.04
-
Unaffected platforms: Windows 10x64, macOS 11
Steps to reproduce
- Download a random file like http://ipv4.download.thinkbroadband.com/5MB.zip.
- Open about:downloads page and right-click on the downloaded item.
- Click on
Always open similar files. - Right-click on the previously downloaded item again.
Expected result
- Always open similar files option has a checkmark in front.
Actual result
- No checkmark is displayed.
Regression range
- I will search for one ASAP if there is one.
Additional notes
- Attached a screen recording.
- Windows 10x64 and macOS 11 are not affected.
- This happens in Private Windows as well.
|
Reporter | |
Updated•2 years ago
|
|
||
Updated•2 years ago
|
|
||
Comment 1•2 years ago
|
||
This is not a regression. Tried searching for a good and bad build using mozregression but the only good builds are the ones in which this functionality is not available.
|
||
Updated•2 years ago
|
|
||
Comment 2•1 year ago
|
||
I can repro on more modern Windows if I enable native menus using the about:config pref (browser.display.windows.non_native_menus to 0).
I... don't understand why it doesn't work? It seems to use type=checkbox and checked=true the same way that e.g. the "menu bar" item in the toolbar context menu uses, and that works fine. And I don't see any difference when looking at styles for those two elements. Maybe it's because it's not in the toplevel document or something? Emilio, can you help?
|
Assignee | |
Comment 3•1 year ago
|
||
Untested, but it should work.
|
||
Updated•1 year ago
|
|
|
Assignee | |
Comment 4•1 year ago
|
||
about:downloads is in a content dochsell, which means it uses the non-native theme... I have a patch that ought to work, but untested because I'm on Linux right now.
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/900fc2b830da Use non-native menus in Windows for documents where we don't have a native theme. r=Gijs
|
||
Comment 6•1 year ago
|
||
| bugherder | ||
|
|
Reporter | |
Comment 7•1 year ago
|
||
Confirming that the issue is fixed on Windows 7x64 and Windows 10x64 (browser.display.windows.non_native_menus:0) with Firefox 112.0a1 (20230216213942) and macOS 12 is still not affected.
However, I can still reproduce the issue on Ubuntu 20.04 with the latest Nightly, should I file a new ticket for this?
Also, I can see that there are some differences in the alignment of the context menu options when the check mark is active between Windows 7 and Windows 10/ macOS 12. Should we file an issue for this as well? Thank you in advance!
|
|
Assignee | |
Comment 8•1 year ago
|
||
Yeah, let's file a new bug for Linux, we don't have non-native checkboxes there unfortunately, so that requires more work.
I wouldn't worry about the alignment differences across platforms, I don't think. But 301 Gijs on that.
|
|
Reporter | |
Comment 9•1 year ago
|
||
Thank you, Emilio. I filled bug 1817422 for Ubuntu and I will fill another if needed for the alignment differences.
|
|
||
Comment 10•1 year ago
|
||
(In reply to Emilio Cobos Álvarez (:emilio) from comment #8)
Yeah, let's file a new bug for Linux, we don't have non-native checkboxes there unfortunately, so that requires more work.
I wouldn't worry about the alignment differences across platforms, I don't think. But 301 Gijs on that.
Huh. That's interesting. The cause is this code: https://searchfox.org/mozilla-central/rev/9de332d5c8faac58dc1232b8a6383ce6cb1400f4/toolkit/content/widgets/menupopup.js#14-34 .
It should use some other check now that we support these menus on other Windows versions. I'll file a follow-up.
|
||
Updated•1 year ago
|
Description
•