Closed Bug 1791020 Opened 2 years ago Closed 2 years ago

Intervention card Help button is no longer aligned with intervention button

Categories

(Firefox :: Address Bar, defect)

Product:
Firefox
Component:
Address Bar
Version:
Firefox 106
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
107 Branch
Tracking Flags:
Tracking Status
firefox-esr102 --- unaffected
firefox105 --- unaffected
firefox106 --- wontfix
firefox107 --- verified

People

(Reporter: phorea, Assigned: daisuke)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

intervention.png
413.51 KB, image/png
Details
Bug 1791020: Adjust vertical position for general help button.
48 bytes, text/x-phabricator-request
Details | Review
Attached image intervention.png —

Note

  • Small unalignment when search interventions are triggered in the address bar

Found in

  • Nightly 106.0a1 2022-09-15

Affected versions

  • Nightly 106.0a1 2022-09-15

Tested platforms

  • Affected platforms: Win 10 64-bit, Ubuntu 22.04, OSX 12
  • Unaffected platforms: -

Steps to reproduce

  1. Type cache firefox string in the address bar
  2. The "Intervention Card" is displayed in the second position of the address bar dropdown
  3. Verify the ? - Get help button

Expected result

  • Help button is aligned with the Choose what to clear intervention button

Actual result

  • Get Help button is placed lower than the intervention button

Regression range

Has STR: --- → yes

:daisuke, since you are the author of the regressor, bug 1783463, could you take a look?

For more information, please visit auto_nag documentation.

Flags: needinfo?(daisuke)

I also could reproduce it, and will take a look at this issue.

Flags: needinfo?(daisuke)
Assignee: nobody → daisuke
Status: NEW → ASSIGNED

Set release status flags based on info from the regressing bug 1783463

status-firefox107: --- → affected
Pushed by dakatsuka.birchill@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9eaf307b35af
Adjust vertical position for general help button. r=daleharvey

https://hg.mozilla.org/mozilla-central/rev/9eaf307b35af

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox107: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 107 Branch

The patch landed in nightly and beta is affected.
:daisuke, is this bug important enough to require an uplift?

  • If yes, please nominate the patch for beta approval.
  • If no, please set status-firefox106 to wontfix.

For more information, please visit auto_nag documentation.

Flags: needinfo?(daisuke)
status-firefox106: affected → wontfix
Flags: needinfo?(daisuke)

Verified as fixed using Nightly 107.a01 across platforms.

Status: RESOLVED → VERIFIED
status-firefox107: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: