Closed Bug 1790407 Opened 2 years ago Closed 2 years ago

Close button is not working for the mobile pick up card

Categories

(Firefox :: Firefox View, defect, P1)

Product:
Firefox
Component:
Firefox View
Platform:
Desktop
All
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
106 Branch
Tracking Flags:
Tracking Status
firefox-esr91 --- unaffected
firefox-esr102 --- unaffected
firefox104 --- unaffected
firefox105 --- unaffected
firefox106 --- verified

People

(Reporter: Gabi, Assigned: niklas)

References

(Blocks 2 open bugs, Regression)

Details

(Keywords: regression, Whiteboard: [fidefe-2022-mr1-firefox-view])

Attachments

(1 file)

Bug 1790407 - Close button for mobile pick up card should be clickable. r=sclements,sfoster
48 bytes, text/x-phabricator-request
Details | Review

Found in

  • Nightly 106.0a1

Affected versions

  • Nightly 106.0a1

Tested platforms

  • Affected platforms: Windows 10x64, Ubuntu 18.4 and macOS 10.12.6

Steps to reproduce

  1. Launch Firefox
  2. Go to Firefox View tab pick up
  3. Click Continue button to sign in with FxA account
  4. Sign In with account
  5. Return to Firefox View and click Close on the mobile pick up card button

Expected result

  • Mobile pick up message card is closed.

Actual result

  • Close button is not working for the mobile pick up card

Regression range

Has STR: --- → yes
Keywords: regression
Has STR: yes → ---
Keywords: regression

Oops. Sorry didn't mean to do that!

Has STR: --- → yes
Keywords: regression

We shouldn't ship with non-functioning buttons.

Severity: S3 → S2
Priority: -- → P1

Agreed. Chatting w/ Sarah about this now.

Regressed by: 1789226

Niklas, would you be able to look at the close button in the mobile promo?

Flags: needinfo?(nbaumgardner)

Set release status flags based on info from the regressing bug 1789226

status-firefox104: --- → unaffected
status-firefox105: --- → unaffected
status-firefox-esr102: --- → unaffected
status-firefox-esr91: --- → unaffected

Yes, I will look into this

Flags: needinfo?(nbaumgardner)
Assignee: nobody → nbaumgardner
Status: NEW → ASSIGNED
Whiteboard: [fidefe-2022-mr1-firefox-view]
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/9c9951c88959
Close button for mobile pick up card should be clickable. r=Gijs

https://hg.mozilla.org/mozilla-central/rev/9c9951c88959

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox106: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 106 Branch

Verified as fixed in Nightly 106.0a1 with Windows 10x64, Ubuntu 18.4 and macOS 10.12.6.

Status: RESOLVED → VERIFIED
status-firefox106: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: