The Synced Tabs menu button is blank
Categories
(Firefox :: Sync, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox-esr91 | --- | unaffected |
| firefox-esr102 | --- | unaffected |
| firefox104 | --- | unaffected |
| firefox105 | + | verified |
| firefox106 | + | verified |
People
(Reporter: vlucaci, Assigned: emilio)
References
(Regression)
Details
(Keywords: regression)
Attachments
(2 files)
|
106.78 KB,
image/png
|
Details | |
|
48 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-release+
|
Details | Review |
2022-09-09_12h39_01.png
Found in
- 106.0a1
Affected versions
- 106.0a1
- 105.0b9
- 104.0.2
Tested platforms
- Affected platforms: macOS12 , Windows 10, Win11 , Ubuntu 22
Steps to reproduce
- Launch FF .
- Go to burger menu and select More Tools.
- Select Customize Toolbar.
- Drag and drop the Synced Tabs button anywhere on the toolbar.
- Select Done.
- Click the Synced tabs button.
Expected result
- The Synced tabs menu and its is properly displayed.
Actual result
- The Synced Tabs menu button is blank.
Regression Range
- First bad: 2022-09-04
- Last good:2022-09-03
- Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=2b31d0ddd06820f8402c2fb1ad0ebba0f7b3604c&tochange=cdf7161e6f07517df7963f6196ead6aea4192073
- Potentially regressed by: 1789114
|
Reporter | |
Comment 1•2 years ago
|
||
Hello Emilio,
The regression range seems to indicate that 1789114 would be the culprit.
Could you please confirm?
|
Assignee | |
Comment 2•2 years ago
|
||
But with block rather than -moz-box, which is the default. These just
want to prevent themselves from getting hidden by:
Why are these using a <toolbarbutton> instead of a <button> I didn't
dig into, but this is the less risky fix, obviously.
|
||
Updated•2 years ago
|
|
||
Updated•2 years ago
|
|
|
Assignee | |
Updated•2 years ago
|
|
||
Comment 3•2 years ago
|
||
The bug is marked as tracked for firefox105 (beta) and tracked for firefox106 (nightly). However, the bug still has low severity.
:markh, could you please increase the severity for this tracked bug? If you disagree with the tracking decision, please talk with the release managers.
For more information, please visit auto_nag documentation.
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/572582f5b7d0 Restore display declaration removed in bug 1789114. r=desktop-theme-reviewers,dao
|
|
Assignee | |
Comment 5•2 years ago
|
||
Comment on attachment 9293922 [details]
Bug 1790003 - Restore display declaration removed in bug 1789114. r=aminomancer
Beta/Release Uplift Approval Request
- User impact if declined: comment 0
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: comment 0
- List of other uplifts needed: none
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Simple partial backout of regressing change.
- String changes made/needed: none
- Is Android affected?: No
|
|
Assignee | |
Updated•2 years ago
|
|
|
||
Comment 6•2 years ago
|
||
Comment on attachment 9293922 [details]
Bug 1790003 - Restore display declaration removed in bug 1789114. r=aminomancer
Approved for 105.0rc1.
|
|
||
Comment 7•2 years ago
|
||
| bugherder uplift | ||
|
||
Comment 8•2 years ago
|
||
| bugherder | ||
|
|
Reporter | |
Comment 9•2 years ago
|
||
Hello
Confirming this issue as verified fixed using 105.0(20220912145803) and 106.0a1(20220912214055).
Verified using macOS 12, Windows 11 and Ubuntu 22.
Description
•