Closed Bug 1789826 Opened 2 years ago Closed 2 years ago

Tab Pickup keyboard hover animation is cut off

Categories

(Firefox :: Firefox View, defect, P3)

Product:
Firefox
Component:
Firefox View
Version:
Firefox 106
Platform:
Desktop
All
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
107 Branch
Tracking Flags:
Tracking Status
firefox106 --- verified
firefox107 --- verified

People

(Reporter: vlucaci, Assigned: kcochrane)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [fidefe-2022-mr1-firefox-view])

Attachments

(2 files)

Hover ring cut off.mov
1019.88 KB, video/quicktime
Details
Bug 1789826 - Update z-index of section headers to prevent focus ring from being obscured r?dao
48 bytes, text/x-phabricator-request
pascalc
: approval-mozilla-beta+
Details | Review
Attached video Hover ring cut off.mov —

Affected versions

  • 106.0a1

Tested platforms

  • Affected platforms: macOS12 , Windows 10
  • Unaffected platforms: Ubuntu 22

Steps to reproduce

  1. Launch FF .
  2. Go to Firefox View section
  3. Login with valid Sync credentials and reach 11% progress in the info banner.
  4. Go to Firefox View section.
  5. Navigate with Tab through all the sections of the page.

Expected result

  • The keyboard navigation selector highlight is properly displayed when navigating each section.

Actual result

  • The keyboard navigation selector highlight is cut off for Tab Pickup section.

Regression range

  • New Feature

Additional notes

  • Improving this would greatly benefit the overall aesthetics of the page and increase the overall UX quality.
Severity: -- → S4
Priority: -- → P3
Assignee: nobody → kcochrane
Status: NEW → ASSIGNED
Pushed by kcochrane@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/88ddc1a229f4
Update z-index of section headers to prevent focus ring from being obscured r=dao

https://hg.mozilla.org/mozilla-central/rev/88ddc1a229f4

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox107: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 107 Branch

Comment on attachment 9295305 [details]
Bug 1789826 - Update z-index of section headers to prevent focus ring from being obscured r?dao

Beta/Release Uplift Approval Request

  • User impact if declined: Visual glitch on the focus ring in Firefox View, a new feature we're shipping in 106
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: See comment 0
  • List of other uplifts needed: N/A
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): 2-line CSS-only change
  • String changes made/needed: Nope
  • Is Android affected?: No
Attachment #9295305 - Flags: approval-mozilla-beta?
Flags: qe-verify+

Comment on attachment 9295305 [details]
Bug 1789826 - Update z-index of section headers to prevent focus ring from being obscured r?dao

Approved for 106.0b4, thanks.

Attachment #9295305 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
QA Whiteboard: [qa-triaged]

Hello,

Confirming this issue as verified fixed on 106.0b4(20220925185751) and 107.0a1(20220925213821) using macOS 12 , Windows 10 and Windows 11.

Status: RESOLVED → VERIFIED
status-firefox106: fixed → verified
status-firefox107: fixed → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: