The PiP's controls don't hide if the subtitle settings panel is being opened and closed by clicking on a random part of the PiP
Categories
(Toolkit :: Picture-in-Picture, defect, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr91 | --- | unaffected |
firefox-esr102 | --- | unaffected |
firefox104 | --- | wontfix |
firefox105 | --- | wontfix |
firefox106 | --- | wontfix |
firefox110 | --- | wontfix |
firefox111 | --- | wontfix |
firefox112 | --- | verified |
People
(Reporter: danibodea, Unassigned)
References
Details
(Keywords: regression, Whiteboard: [fidefe-MR1-2022])
Note
- When the user loads and plays any video with supported subtitles inside PiP, clicks on the subtitle settings button and then on the PiP to close it (not on the subtitle settings button again) and hovers outside of PiP, he will notice that the PiP's controls do not hide, as they should.
Found in
- Nightly v106.0a1
Affected versions
- Nightly v106.0a1
- Beta v105.0b6
- Release v104.0
- Release v103.0
- Release v102.0.1 - disabled (sub settings button not implemented)
Tested platforms
- Affected platforms: Windows 10, Ubuntu 22, Mac OS 11.
- Unaffected platforms: -
Steps to reproduce
- Load any video with subtitles supported in PiP.
- Enable subs and launch PiP.
- Click the subtitle settings button.
- Click on the PiP to close the panel (not on the button).
- Move the cursor outside of the PiP area.
Expected result
- The PiP's buttons go away / disappear after a few seconds.
Actual result
- The buttons no longer go away.
Regression range
- First bad: Tested mozilla-central build: 2022-06-30 (verdict: b)
- Last good: Tested mozilla-central build: 2022-06-29 (verdict: g)
- I've attempted to come up with a regressor/pushlog, but it got complicated because there are many changes regarding the behavior of the subtitles panel and buttons around that time range.
Updated•2 years ago
|
Updated•2 years ago
|
Updated•2 years ago
|
Updated•2 years ago
|
We use a custom donthide
attribute for the controls to keep the them visible whenever we're using subtitles settings panel. However, we only remove the attribute after clicking the subtitles button. We should find a way to remove this attribute after the panel hides from clicking anywhere on the PiP window.
Reporter | ||
Comment 2•1 year ago
|
||
I decided to upgrade the severity of this issue to S3 considering the annoying behavior it causes when the buttons don't go away to let the subtitles be displayed lower to leave the center of the video visible.
Updated•1 year ago
|
Comment 3•1 year ago
|
||
Hey Daniel,
I think this bug is a duplicate of bug 1812939 which just got fixed.
Can you confirm if this bug is fixed in 112?
Thanks!
Reporter | ||
Comment 4•1 year ago
|
||
I have verified this behavior in Windows 10, MacOS 11 and Ubuntu 22. This issue appears fixed in Nightly v112.0a1. Thank you.
Updated•1 year ago
|
Description
•