Closed
Bug 1788780
Opened 2 years ago
Closed 2 years ago
Removed unused telemetry variables `lastScreenX` and `lastScreenY` from player.js
Categories
(Toolkit :: Picture-in-Picture, task, P4)
Toolkit
Picture-in-Picture
Tracking
()
RESOLVED
FIXED
106 Branch
| Tracking | Status | |
|---|---|---|
| firefox106 | --- | fixed |
People
(Reporter: kpatenio, Assigned: avery, Mentored)
References
Details
Attachments
(1 file)
Two variables this.lastScreenX and this.lastScreenY are remnants of Bug 1764358 that are no longer used in code (searchfox). Let's remove them to clean up the PiP code base a bit.
|
Assignee | |
Comment 1•2 years ago
|
||
|
||
Updated•2 years ago
|
Assignee: nobody → mozilla
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•2 years ago
|
||
Hi :kpatenio, this is my first time trying to contribute to Mozilla, this bug seemed like an easy fix to start with. Please let me know if I missed anything!
Pushed by kpatenio@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7201d87a715a Remove unused telemetry variables `lastScreenX` and `lastScreenY`. r=kpatenio
(In reply to Avery [:avery] from comment #2)
Hi :kpatenio, this is my first time trying to contribute to Mozilla, this bug seemed like an easy fix to start with. Please let me know if I missed anything!
Hello! Apologies - I somehow missed your comment here. I recently approved and landed your patch. Thanks again for your contribution!
|
||
Comment 5•2 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox106:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 106 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•