Note

• Only Ubuntu 22 platform is affected, latest nightly 106.0a1 (2022.08.31) not affected.

Found in

• Firefox 105.0b5

Affected versions

• Firefox 105.0b5

Tested platforms

• Affected platforms: Ubuntu 22.04 x64
• Unaffected platforms: Windows 10 x64 and macOS 10.15

Steps to reproduce

1. Launch Firefox and open the Web Console.
2. Type await 1; alert("bugqypj")
3. Hit Enter key.

Expected result

• The "bugqypj" dialog is displayed without cutting the bottom part of the characters.

Actual result

• The "bugqypj" dialog is displayed cutting the bottom part of the characters.

Regression range

• I will come back with regression range ASAP.

Timea, is it only visible from the console, or can you see it if you open a tab with data:text/html,<meta charset=utf8><script> alert("bugqypj")</script> ?

Yes, I see the same if I open a tab with: data:text/html,<meta charset=utf8><script> alert("bugqypj")</script>, attached image(1).png.

okay, let's move it to the right component then

(FWIW, I don't reproduce on Ubuntu 20.04)

Nicolas, testing more this issue I discovered that it also reproduces on latest nightly with Ubuntu 22. The same issue reproduces for me on Windows and macOS platforms too. I open a tab with data:text/html,<meta charset=utf8><script> and when the alert appear click on Ok then refresh the tab sometimes, or click enter in the url to access again the alert, the issue appears randomly.
With these added steps does it reproduce for you?

Oh yes, I got it on OSX too

Disabling this rule https://searchfox.org/mozilla-central/rev/1d861901b6682ef2e191b9f7683eb267bdd131e2/toolkit/components/prompts/content/commonDialog.css#79-81 fixes the bug, but this is not new, and the file wasn't modified for more than a year.

Gijs, since it looks like you made some changes in this area, would you know what's happening here?

Not off-hand and I don't have a lot of spare cycles to investigate at the moment, unfortunately.

Can someone determine a regression window? That would likely explain the apparent discrepancy in comment #5.

Regression range

• First bad: 20210414160838 (2021-04-14)
• Last good: 20210413214314 (2021-04-13)
• Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=aa432f04a7da3f25eea116cd5548bc9c8554f18c&tochange=48a99646f183abc34e8eeb695fcede5bcc9463d1

(In reply to Timea Zsoldos [:zstimi/tzsoldos], Desktop Release QA from comment #7)

Regression range

• First bad: 20210414160838 (2021-04-14)
• Last good: 20210413214314 (2021-04-13)
• Pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=aa432f04a7da3f25eea116cd5548bc9c8554f18c&tochange=48a99646f183abc34e8eeb695fcede5bcc9463d1

This points to bug 1704616 which suggests this problem was created as part of proton.

It would be useful if someone could figure out why this reproduces randomly as per comment 4 / 5 - maybe it's to do with the additional checkbox (to disable further prompts) that gets added to the dialog?

Itiel, I don't suppose you have time to look into the layout of these dialogs by any chance? ("No" is a perfectly valid answer!)

I'll see what I can do.

I can reproduce this also on Windows 10 if I try to load that data:text/html a few times.
I think the true regressor is bug 1693277, and there are a few factors causing this.
In D107111 these rules were added:
https://searchfox.org/mozilla-central/source/toolkit/components/prompts/content/commonDialog.css#45-47,92-94
Toggling either of these fixes this, but I think the underlying issue is this:
https://searchfox.org/mozilla-central/rev/fa81b64fc1a339e2b2b1f6a8637a689916e13c4e/toolkit/modules/SubDialog.jsm#557
On my system when the issue doesn't reproduce (which happens usually), that var equals 131px, but when it does, it equals 128px.

So bottom line, I think --doc-height-px is being set too early sometimes when the layout hasn't finished rendering, or something.
Not sure how to fix it though...

I believe this was fixed in bug 1819664.