Closed Bug 1788103 Opened 2 years ago Closed 2 years ago

support inline functions in webapp

Categories

(Socorro :: Webapp, enhancement, P2)

enhancement

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: willkg, Assigned: willkg)

References

Details

Attachments

(2 files)

Debug sym files can have inline function information. When we update the stackwalker (bug #1779630), then the stackwalker will be outputting inline function information.

This bug covers figuring out what changes we need to make in the Socorro processor and webapp and making them or spinning off new bugs.

It's probably something along the lines of:

  1. add the relevant bits to the processed crash schema
  2. figure out how to display inline function information in the crashing thread stack in the Crash Stats report view
  3. figure out whether we want to factor inline function information into signature generation
Assignee: nobody → willkg
Status: NEW → ASSIGNED
Summary: support inline functions → support inline functions in webapp
Depends on: 1788267
Priority: -- → P2
Blocks: 1398533

This got pushed to prod in bug #1789701. I told Markus about it. He mentioned that when he asked on #crashreporting-wg, people preferred the other mockup.

mstange: when I asked for opinions on this channel, two or three people said the preferred separate rows for each inline, with "trust" set to "inlined"

My minor issue was that I found the frame numbering confusing. Markus suggested this:

mstange: yeah you'd have two different types of frame indexes

"normal frame index" and "frame index after inline expansion"

or you could just repeat the same frame index, I think that would be fine too

I'll fix the implementation to match that.

PR 6181 changes the display to the other mockup. It also fixes the ordering which Nika pointed out was wrong. Now it displays inline functions and then the frame function.

This was deployed in bug #1790053. Marking as FIXED.

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: