Closed Bug 1787504 Opened 2 years ago Closed 2 years ago

Text recognition modal's scrollbar overlaps the pulled text

Categories

(Core :: DOM: Core & HTML, defect)

Unspecified
macOS
defect

Tracking

()

VERIFIED FIXED
106 Branch
Tracking Status
firefox105 --- disabled
firefox106 --- verified

People

(Reporter: pmagyari, Assigned: gregtatum)

References

(Blocks 1 open bug)

Details

Attachments

(4 files)

Attached image non-hover to hover.png

Note

  • Make sure "dom.text-recognition.enabled"=true in about:config.

Found in

  • Firefox Beta 105.0b2

Affected versions

  • Firefox Beta 105
  • Firefox Nightly 106

Affected platforms

  • MacOS 10.15
  • MacOS 11.6
  • MacOS 12.4

Steps to reproduce

  1. Open browser.
  2. Navigate to: https://s3.amazonaws.com/libapps/accounts/812/images/walkonthemoonnewspaper.jpeg
  3. Right-click on the image to open the context menu.
  4. Select the "Copy Text From Image" command.
  5. Since the pulled text is long a scrollbar appears inside the text recognition modal.

Expected result

  • The scrollbar does not overlap the text inside the modal.

Actual result

  • The scrollbar overlaps the pulled text in the modal.

Additional note

  • When hovering over the scrollbar, it overlaps it even more and also becomes non-see-through.

Regression range

  • This is not a regression.
Has STR: --- → yes
Assignee: nobody → gtatum
Status: NEW → ASSIGNED

I don't understand why this needs an special-case, this is just macOS' scrollbar behavior?

Attached image image.png

I've handled this type of overflow special for macOS in the past, for instance in the Firefox Profiler. It seems like macOS tries to including padding in scroll elements in native menus. Here is an example help menu where the scollbar is not over text.

I'm not strongly opinionated here, but it seems somewhat nicer to have a gutter available for the scrollbar.

Attached image image.png

Here is Safari's alert modal for comparison. The overflow text bar appears middle aligned on the right edge of the box, so it does have some overlap, but less than the current Firefox behavior here.

Pushed by gtatum@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c72ede90daac
Add a scrollbar gap for text recognition modal; r=nordzilla
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 106 Branch

I have verified the fix using Nightly 106.0a1 (20220911214030) on MacOS 10.15, MacOS 11.6 and MacOS 12.4.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: