Closed Bug 1787495 Opened 2 years ago Closed 2 years ago

When text is pulled from an image automatically it adds an extra "space" at the end

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Platform:
Unspecified
macOS
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
106 Branch
Tracking Flags:
Tracking Status
firefox105 --- disabled
firefox106 --- verified

People

(Reporter: pmagyari, Assigned: gregtatum)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1787495 - Make recognized text consistently use double line endings per cluster; r?nordzilla
48 bytes, text/x-phabricator-request
Details | Review

Note

  • Make sure "dom.text-recognition.enabled"=true in about:config.

Found in

  • Firefox Beta 105.0b2

Affected versions

  • Firefox Beta 105
  • Firefox Nightly 106

Affected platforms

  • MacOS 10.15
  • MacOS 11.6
  • MacOS 12.4

Steps to reproduce

  1. Open browser.
  2. Navigate to: https://bit.ly/3QV8Op7
  3. Right-click on the image to open the context menu.
  4. Select the "Copy Text From Image" command.
  5. Close the modal by either hitting "ESC" or clicking the "Close" button.
  6. Open a new tab and paste the pulled text into the URL bar.

Expected result

  • The text is copied as-is, without any extra characters or "spaces".

Actual result

  • The text has a extra "spaces" at the end of it.

Additional note

  • This only occurs when pasting the "automatically" pulled text, it does not occur when copying text manually by using "Cmd+C".

Regression range

  • This is not a regression.
Summary: When text is pulled from an image automatically it has an extra "space" at the end → When text is pulled from an image automatically it adds an extra "space" at the end
Has STR: --- → yes
Assignee: nobody → gtatum
Status: NEW → ASSIGNED

Each paragraph in the solution should have two newlines at the end of it. The end of the entire text should not have any whitespace. This patch makes the automatically copied text and the highlighted and copied text consistent.

Pushed by gtatum@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cd83df616e8f
Make recognized text consistently use double line endings per cluster; r=nordzilla

https://hg.mozilla.org/mozilla-central/rev/cd83df616e8f

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox106: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 106 Branch

I have verified the fix using Nightly 106.0a1 (20220911214030) on MacOS 10.15, MacOS 11.6 and MacOS 12.4.

Status: RESOLVED → VERIFIED
status-firefox106: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: