Closed Bug 1782685 Opened 2 years ago Closed 1 year ago

[DNR] Ship DNR API on release

Categories

(WebExtensions :: Request Handling, task, P2)

task

Tracking

(firefox113 fixed)

RESOLVED FIXED
113 Branch
Tracking Status
firefox113 --- fixed

People

(Reporter: robwu, Assigned: robwu)

References

(Blocks 1 open bug)

Details

(Keywords: dev-doc-complete, Whiteboard: [addons-jira])

Attachments

(2 files)

This bug is about flipping the extensions.dnr.enabled pref to true (or even removing the pref).

Severity: -- → N/A
Priority: -- → P2
Depends on: 1797403
Depends on: 1797404
Depends on: 1801870
Depends on: 1803365
Depends on: 1810753
Depends on: 1811498
Depends on: 1811947
Depends on: 1821051

With the implementation having been mostly completed, we want to do some optimization work and then ship the API. That means:

  • Make the API available to MV2 and MV3.
  • Do not require a preference to use the API.

Before shipping, we should consider whether to ship with the current implementation of regexFilter as is, or whether to strictly validate and restrict the syntax (bug 1821033). The advantage of the current implementation is that the regexFilter syntax is now identical to JS, the disadvantage is that the syntax may be broader than required in practice. If we were to restrict the syntax in the future, that could potentially break extensions. For more details on regexFilter, follow bug 1821033.

See Also: → 1821033
Whiteboard: [addons-jira]
See Also: → 1821676
Pushed by rob@robwu.nl:
https://hg.mozilla.org/integration/autoland/rev/03d9da4ac52f
Remove MV3 requirement from DNR r=rpl
https://hg.mozilla.org/integration/autoland/rev/ecda751ce0ea
Turn on availability of DNR API r=rpl
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 113 Branch

Is this something we want to call out in the Fx113 relnotes? Please nominate if so.

Flags: needinfo?(rob)

We usually do not call out extension API in the user release notes. We will add it to the Firefox release notes for developers article on MDN.

Flags: needinfo?(rob)

The following documentation updates have been made:

  • MDN content
  • #26142 (Release note, merged),
  • #26168 (optional and no prompt permissions update)
  • BCD #19362
Flags: needinfo?(rob)

I have posted reviews/feedback on the issues, and expect them to be resolved eventually. Marking as dev-doc-complete.

PS. The majority of the DNR documentation was authored in https://github.com/mdn/content/pull/22644 and https://github.com/mdn/browser-compat-data/pull/18403

Flags: needinfo?(rob)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: