File URL should be decoded in devtools UI
Categories
(DevTools :: Debugger, defect)
Tracking
(firefox105 fixed)
| Tracking | Status | |
|---|---|---|
| firefox105 | --- | fixed |
People
(Reporter: extophf, Assigned: ochameau)
Details
Attachments
(2 files)
- open the attached test.html
- open devtools -> Debugger -> Sources
- expand foo://
What happened?
URL is garbled: æåã³ã¼ã.js
What should have happened?
URL is readable: 文字コード.js
Anything else we should know?
SourcesTreeItem.js in Firefox's devtools uses unescape which doesn't decode URLs. It was added in FF67 AFAICS: https://hg.mozilla.org/integration/mozilla-inbound/rev/6b5b546aac14
decodeURI or decodeURIComponent should be used instead, arguably, but it can throw on invalid characters, so unescape should be used as a fallback.
|
||
Comment 1•2 years ago
|
||
Hi Tophf,
Thanks for filling this issue.
I can reproduce the issue in Firefox 103. But it looks like its fixed in the Latest Nightly (Firefox 105).
Could you try out the latest firefox nightly?
Thanks
|
|
||
Comment 3•2 years ago
|
||
Thanks for confirming! i'll close this.
|
Assignee | |
Comment 4•2 years ago
|
||
This at least ensure that the sources display with the right display in the Source Tree.
|
||
Updated•2 years ago
|
|
|
Assignee | |
Comment 5•2 years ago
|
||
Reopening to add some test to ensure not regressing this.
Pushed by apoirot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e9bd0a704230 [devtools] Test files with encoded characters in the debugger. r=bomsy
|
||
Comment 7•2 years ago
|
||
| bugherder | ||
Description
•