Fix handling of undefined in pointerMove and wheel actions
Categories
(Remote Protocol :: Marionette, defect, P1)
Tracking
(firefox107 fixed)
| Tracking | Status | |
|---|---|---|
| firefox107 | --- | fixed |
People
(Reporter: jgraham, Assigned: jgraham)
References
(Blocks 1 open bug)
Details
(Whiteboard: [webdriver:m4][webdriver:external], [wptsync upstream])
Attachments
(1 file)
The spec currently says it's OK to pass in undefined as x, y in pointer move and wheel scroll actions, and also deltaX and deltaY in wheel scroll actions. But it then goes on to assume that those values are integers.
The spec should change to require that those fields are not undefined, and the implementation in geckodriver/marionette updated to match.
|
Assignee | |
Comment 1•2 years ago
|
||
|
|
Assignee | |
Comment 2•2 years ago
|
||
The spec claims that undefined is allowed for these values, but later
treats them as if they're always integers. I suspect the original
intent was to default to 0, but since there seems to be interop around
rasing an exception, make geckodriver and marionette explicitly check
for valid integers and disallow missing/undefined values.
|
||
Updated•2 years ago
|
|
||
Updated•2 years ago
|
|
||
Comment 3•2 years ago
|
||
The severity field is not set for this bug.
:whimboo, could you have a look please?
For more information, please visit auto_nag documentation.
|
||
Updated•2 years ago
|
|
|
||
Comment 4•2 years ago
|
||
As it looks like this patch waits for bug 1746601 to be fixed? I'm going to add the dependency.
|
|
||
Updated•2 years ago
|
|
|
||
Comment 5•2 years ago
|
||
FYI the referenced pull request has been merged last week. So we are good to go with landing a patch.
|
|
||
Comment 6•2 years ago
|
||
James, I assume we should get this landed as well for the 0.32.0 release of geckodriver. Do you agree? If yes we should be able to get the patch reviewed?
|
|
Assignee | |
Comment 7•2 years ago
|
||
Yes, I think we should review and land this if possible.
Failed to create upstream wpt PR due to merge conflicts. This requires fixup from a wpt sync admin.
|
||
Comment 9•2 years ago
|
||
Backed out for causing linting failures.
Backout link: https://hg.mozilla.org/integration/autoland/rev/0f26fe30b1c7db9255c9778404ad8c0679600da8
Failure log: https://treeherder.mozilla.org/logviewer?job_id=390489268&repo=autoland&lineNumber=223
|
||
Comment 10•2 years ago
|
||
Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/autoland/rev/2df6d549261a Disallow missing pointerMove / wheel scroll coordinates, r=webdriver-reviewers,whimboo
|
|
||
Comment 11•2 years ago
|
||
| bugherder | ||
|
|
||
Updated•2 years ago
|
|
|
||
Comment 12•2 years ago
|
||
James, the upstream wptsync failed here before and I assume this happened again? I cannot find a listed PR here. Maybe you can have a look?
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/36054 for changes under testing/web-platform/tests
|
|
Assignee | |
Updated•2 years ago
|
|
|
||
Comment 14•2 years ago
|
||
(In reply to Web Platform Test Sync Bot (Matrix: #interop:mozilla.org) from comment #13)
Created web-platform-tests PR
https://github.com/web-platform-tests/wpt/pull/36054 for changes under
testing/web-platform/tests
Note that this PR got already merged three days ago even there was no update from the bot.
|
||
Updated•1 year ago
|
Description
•