Marionette window restoration is broken on Linux automation
Categories
(Core :: Widget: Gtk, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox104 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
References
Details
(Whiteboard: [webdriver:relnote])
Attachments
(4 files)
Which is why I needed to annotate tests in bug 1779559. Pre-existing failures are in: https://searchfox.org/mozilla-central/rev/fa71140041c5401b80a11f099cc0cd0653295e2c/testing/web-platform/meta/page-visibility/minimize.html.ini
This seems to be because gtk_window_deiconify doesn't actually deiconify the window, so the sizemodechange never arrives.
|
Assignee | |
Comment 1•2 years ago
|
||
These don't change behavior but I did them while debugging this.
|
|
Assignee | |
Comment 2•2 years ago
|
||
Like we do to maximize/fullscreen. This makes the code less confusing
and more reliable over-all.
Depends on D152176
|
|
Assignee | |
Comment 3•2 years ago
|
||
This does work on Mutter, while gtk_window_deiconify doesn't seem to,
see:
for example.
Depends on D152177
|
|
Assignee | |
Comment 4•2 years ago
|
||
Depends on D152178
|
||
Updated•2 years ago
|
|
|
||
Updated•2 years ago
|
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/409297c79d2d Miscellaneous clean-ups to related code. r=Gijs
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/598d4ad77f18 Consistently use sizemodechange events to minimize/restore windows. r=webdriver-reviewers,jdescottes https://hg.mozilla.org/integration/autoland/rev/0fcbd8d0d597 Use gtk_window_present too, to deiconify windows. r=stransky https://hg.mozilla.org/integration/autoland/rev/692f47ec667f Update test expectations. r=jdescottes
|
||
Comment 7•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/409297c79d2d
https://hg.mozilla.org/mozilla-central/rev/598d4ad77f18
https://hg.mozilla.org/mozilla-central/rev/0fcbd8d0d597
https://hg.mozilla.org/mozilla-central/rev/692f47ec667f
|
||
Comment 8•2 years ago
|
||
Emilio, thanks a lot for these changes! They are pretty helpful and make both minimizing and restoring windows way faster. I no longer see the TimedPromise error with a 5s timeout. Now the commands return immediately - which is a drastic improvement!
|
|
||
Updated•2 years ago
|
Description
•