Closed Bug 1779457 Opened 2 years ago Closed 2 years ago

Extend bug 1764354 to apply to content as well.

Categories

(Core :: SVG, task)

task

Tracking

()

RESOLVED FIXED
105 Branch
Tracking Status
firefox104 --- disabled
firefox105 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

Details

(Keywords: dev-doc-complete)

Attachments

(3 files)

Assignee: nobody → emilio
Status: NEW → ASSIGNED
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/33fbecca098c
Make prefers-color-scheme of SVG images match embedder on content too. r=aosmond
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/34845 for changes under testing/web-platform/tests
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/autoland/rev/34f9bcdd17ff
Annotate some tests as failing when using drawSnapshot while I investigate.
Blocks: 1779592
Upstream PR merged by moz-wptsync-bot
Regressions: 1779874

Approval Request Comment
[Feature/Bug causing the regression]: none
[User impact if declined]: We don't want to ship this feature as-is. It needs a minor change in bug 1782595, but since we also need to extend the feature to iframes (bug 1782596), it seems probably wiser to just turn it off in 104 and ship both things at the same time.
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: N/A
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: Prefs off feature to go to the previous behavior for at least one more cycle.
[String changes made/needed]: No

Attachment #9288036 - Flags: approval-mozilla-beta?

Comment on attachment 9288036 [details] [diff] [review]
Turn this off on beta, for now

Approved for 104.0b6

Attachment #9288036 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Target Milestone: 104 Branch → 105 Branch

FF105 Docs for this can be tracked in https://github.com/mdn/content/issues/19449. We'll start a little closer to the release.

Emilio, is there a way of knowing when the discussion of the WG will make it into the specification? That way I can create a subfeature for this with a link to the specification in the browser compatibility data.

Flags: needinfo?(emilio)

Well, someone needs to send a PR to the specification, or the editors will make the edits themselves. So no great way to know.

Flags: needinfo?(emilio)

Thanks Emilio. I'm not sure an intent to accept this update to the spec is far enough along to mark this as "standard" in the browser compatibility data. So I'll probably have to mark as non-standard. If you create or see said PR can you please ping me.

I've removed the dev-docs-needed keyword as there is documentation added for this in the following tracking issue on GitHub.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: