Add Realm support to "target" argument for "script.evaluate", "script.callFunction", and "script.disown"
Categories
(Remote Protocol :: WebDriver BiDi, enhancement, P1)
Tracking
(firefox106 fixed, firefox107 fixed)
People
(Reporter: whimboo, Assigned: Sasha)
References
Details
(Whiteboard: [webdriver:m4], [wptsync upstream])
Attachments
(3 files)
|
48 bytes,
text/x-phabricator-request
|
pascalc
:
approval-mozilla-beta+
|
Details | Review |
|
48 bytes,
text/x-phabricator-request
|
pascalc
:
approval-mozilla-beta+
|
Details | Review |
|
48 bytes,
text/x-phabricator-request
|
pascalc
:
approval-mozilla-beta+
|
Details | Review |
Once we have sandbox support for script.evaluate (bug 1770480) and can retrieve existing realms (bug 1766240) we can finally add Realm support for the target argument.
|
Reporter | |
Comment 1•2 years ago
|
||
Given the small differences to script.callFunction lets cover both on the same bug.
|
||
Updated•2 years ago
|
|
|
||
Updated•2 years ago
|
|
|
Reporter | |
Updated•2 years ago
|
|
|
Reporter | |
Comment 2•2 years ago
|
||
We should wait until the script.disown command has been implemented as well.
|
Assignee | |
Updated•2 years ago
|
|
|
Assignee | |
Comment 3•2 years ago
|
||
Depends on D156051
|
|
Assignee | |
Comment 4•2 years ago
|
||
Depends on D156690
|
|
Assignee | |
Comment 5•2 years ago
|
||
Depends on D156690
Pushed by aborovova@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4379621516e9 [bidi] Add Realm support to "target" argument for "script.evaluate", "script.callFunction" and "script.disown" r=webdriver-reviewers,jdescottes,whimboo https://hg.mozilla.org/integration/autoland/rev/db18156a5524 [wdspec] Move argument and this argument callFunction tests to separate files. r=webdriver-reviewers,jdescottes https://hg.mozilla.org/integration/autoland/rev/f1387a8dfb7f [wdspec] Add tests for realm in target argument for "script.evaluate", "script.callFunction" and "script.disown". r=webdriver-reviewers,whimboo,jdescottes
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/35962 for changes under testing/web-platform/tests
|
||
Comment 8•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/4379621516e9
https://hg.mozilla.org/mozilla-central/rev/db18156a5524
https://hg.mozilla.org/mozilla-central/rev/f1387a8dfb7f
|
|
Assignee | |
Comment 9•2 years ago
|
||
Comment on attachment 9293492 [details]
Bug 1779231 - [bidi] Add Realm support to "target" argument for "script.evaluate", "script.callFunction" and "script.disown"
Beta/Release Uplift Approval Request
- User impact if declined: A user will not be able to start using "script.evaluate", "script.callFunction" and "script.disown" commands.
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: Bug 1778976
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): It introduces only a new functionality to the BiDi commands, all the changes are tests with wdspec tests.
- String changes made/needed:
- Is Android affected?: Yes
|
|
Assignee | |
Updated•2 years ago
|
|
||
Comment 10•2 years ago
|
||
Comment on attachment 9293492 [details]
Bug 1779231 - [bidi] Add Realm support to "target" argument for "script.evaluate", "script.callFunction" and "script.disown"
Approved for 106.0b3, thanks.
|
|
||
Updated•2 years ago
|
|
|
||
Updated•2 years ago
|
|
|
||
Comment 11•2 years ago
|
||
| bugherder uplift | ||
https://hg.mozilla.org/releases/mozilla-beta/rev/f365465f6d6d
https://hg.mozilla.org/releases/mozilla-beta/rev/25bc83e275ed
https://hg.mozilla.org/releases/mozilla-beta/rev/3f01c4c4e597
Upstream PR merged by jgraham
Description
•