Support serialization of plain JS objects with simple value fields
Categories
(Remote Protocol :: WebDriver BiDi, task, P1)
Tracking
(firefox105 fixed)
| Tracking | Status | |
|---|---|---|
| firefox105 | --- | fixed |
People
(Reporter: jdescottes, Assigned: Sasha)
References
(Blocks 1 open bug)
Details
(Whiteboard: [webdriver:m4][webdriver:relnote])
Attachments
(1 file)
The serialization added in Bug 1770752 is not handling plain JS objects.
However they are already handled by the deserialization, so it could be nice to support them, similarly to how we support other collections such as maps, arrays, sets etc...
Plain JS object can be identified using ChromeUtils.getClassName(obj) == "Object".
xpcshell tests can be added to cover this. Existing wdspec tests also indirectly cover this.
|
||
Comment 1•2 years ago
|
||
We should keep in mind that this if condition is fine for the moment but once we have implemented the serialization of all the other types the serialization of plain objects should be the fallback and as such the if condition needs to be removed.
|
||
Comment 2•2 years ago
|
||
The other option would be to add this as the fallback and have explicit branches for the types we don't support that raise an error.
|
Reporter | |
Updated•2 years ago
|
|
Assignee | |
Updated•2 years ago
|
|
|
Assignee | |
Comment 3•2 years ago
|
||
Pushed by aborovova@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a8595c1dd7fc Add support for serialization of plain JS objects with simple value fields. r=webdriver-reviewers,jdescottes
|
||
Comment 5•2 years ago
|
||
| bugherder | ||
|
|
||
Updated•2 years ago
|
Description
•