Private default engine is not glean reported when default set
Categories
(Firefox :: Search, defect, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox-esr91 | --- | unaffected |
| firefox-esr102 | --- | wontfix |
| firefox101 | --- | unaffected |
| firefox102 | --- | wontfix |
| firefox103 | --- | wontfix |
| firefox104 | --- | wontfix |
| firefox105 | --- | verified |
People
(Reporter: aflorinescu, Assigned: msmolens, Mentored)
References
(Blocks 1 open bug)
Details
(Keywords: good-first-bug, Whiteboard: [lang=js])
Attachments
(2 files)
glean_default_private_engine.jpg
Affected versions
- Nightly 102
Affected platforms
- Windows 10
- Ubuntu 22.04
- Mac 11
Steps to reproduce
- Open Firefox.
- Opena about:config and set browser.search.separatePrivateDefault.ui.enabled to true
- Open about:glean
- In the "Tag all sent pings with this tag" field input the desired tag.
- Input metrics into the "Send the named ping" field and press submit settings.
- Open about:preferences#search and enable default private engine to be different from the default engine, but select the same engine.
- Submit a new glean ping (redo str. 3,4,5)
Expected result
Default Private engine is reported for both the case where the default private is the same or different from the default engine.
Actual result
For the case in which the default private engine is not specifically set, it is not reported correctly.
Regression range
Not a regression.
|
||
Updated•2 years ago
|
|
||
Comment 1•2 years ago
|
||
Taking a look at this, it seems it is only an issue when initially toggling the browser.search.separatePrivateDefault.ui.enabled preference. After a restart, the telemetry is correct. We are skipping reporting telemetry when something has changed but the private & default engines match.
Hence we should fix this but it isn't a priority yet as it might be a bit longer before we enable it.
Setting as a good-first-bug, as I think this would be good for someone to take. We should also extend/add a test in this test file to extend the checks on the glean telemetry for this case.
|
Assignee | |
Comment 2•2 years ago
|
||
|
||
Updated•2 years ago
|
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8b6ce020acc1 Update default search engine telemetry when changing separatePrivateDefault preferences. r=Standard8
|
||
Comment 4•2 years ago
|
||
| bugherder | ||
|
||
Comment 5•2 years ago
|
||
Since nightly and release are affected, beta will likely be affected too.
For more information, please visit auto_nag documentation.
|
|
||
Updated•2 years ago
|
|
||
Updated•2 years ago
|
|
Reporter | |
Comment 6•2 years ago
|
||
I will mark this as verified (Ubuntu 22, Windows 10, Mac11 with Firefox 105.0.2).
Firefox 105+ private engine reporting has had some additions - but accounting for those is done on separate threads.
Description
•