Adaptive autofill overwrite effect in case of http SearchString
Categories
(Firefox :: Address Bar, defect, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox102 | --- | verified |
People
(Reporter: vlucaci, Assigned: daisuke)
References
(Blocks 1 open bug)
Details
Attachments
(3 files)
Affected versions
- 102.0a1(20220518214245)
Affected platforms
- macOS 11
- Windows 11
- Windows 10
- Ubuntu 20
Steps to reproduce
- Launch Firefox.
- Go to this http page
- Open a new tab and close the page from step 2.
- In the new tab , write "ht"
Expected result
- The Autofill should not give any suggestions to the http page page from history , after inputting only two of the following letters "ht".
Actual result
- The http page is autofilled as soon as the user only inputs "ht"
|
||
Comment 1•2 years ago
•
|
||
Seems that the behavior originally in description has been fixed by bug 1769585. Reusing this bug for the overwrite effect in case of http (see attachment), although this also might be invalid depending on bug 1770164 resolution.
|
|
||
Updated•2 years ago
|
|
||
Comment 2•2 years ago
|
||
Here's the video on Google Drive, which makes it easier to watch for me: https://drive.google.com/file/d/1uET_DwLe332mzkTDHo5NWs1kpzQN-HNu/view?usp=sharing
|
|
||
Comment 3•2 years ago
|
||
This is a weird one. I can reproduce with these STR:
- Enable adaptive history autofill
- Paste
http://info.cern.ch/in the urlbar and press enter - Open a new tab and close the tab from the previous step
- Type
httpand pick the URL result from step 1 - Type
httpagain
At this point "http.cern.ch/" autofills, which is wrong, but the heuristic result's URL is http://info.cern.ch/, which is right. So when you press enter, you visit the correct URL.
Clearly we're not handling prefixes and/or fixup_url() in the SQL correctly.
|
Assignee | |
Comment 4•2 years ago
|
||
I could reproduce this issue too. I will take a look at this.
|
|
Assignee | |
Comment 5•2 years ago
|
||
Hi Drew.
I found the reason for the issue of your STR, and could fix.
And, one more thing. If we input http://, it can't autofill by another reason below.
https://searchfox.org/mozilla-central/rev/a688eb56e8f69acef88bbad1b224b5bd70dba842/browser/components/urlbar/UrlbarProviderAutofill.jsm#293-300
Here, I want to ask you, I think we better make autofill available even if user's input is "http://" at least for adaptive history autofill, but what do you think?
|
|
||
Comment 6•2 years ago
|
||
Yeah, I agree, it should be possible to use a prefix (or part of a prefix) for adaptive history autofill. We should still require a non-empty search string for origin and URL autofill though. We'll need to modify that early return you linked, but we'll need to be careful not to try to do origin and URL autofill if the search string is empty.
|
|
Assignee | |
Comment 7•2 years ago
|
||
Okay, thank you so much!
|
|
Assignee | |
Comment 8•2 years ago
|
||
|
|
Assignee | |
Comment 9•2 years ago
|
||
Depends on D147128
|
||
Comment 10•2 years ago
|
||
Pushed by dakatsuka.birchill@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/725965204d39 Autofill with fixed_url when user's input matches with it. r=adw https://hg.mozilla.org/integration/autoland/rev/44a4d0fa1095 Make autofilling available when user's input expresses a protocol like 'http://'. r=adw
|
||
Comment 11•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/725965204d39
https://hg.mozilla.org/mozilla-central/rev/44a4d0fa1095
|
||
Updated•2 years ago
|
|
||
Comment 12•2 years ago
|
||
Verified as fixed on Firefox 102 beta 4 and latest Nightly 103.0a1 under Win 10 64-bit, Ubuntu 22.04 and OSX 12.
Description
•