The PiP's buttons don't show a highlight on hover when in full screen
Categories
(Toolkit :: Picture-in-Picture, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr91 | --- | unaffected |
firefox100 | --- | wontfix |
firefox101 | --- | wontfix |
firefox102 | --- | wontfix |
firefox103 | --- | fixed |
People
(Reporter: danibodea, Assigned: janvi01)
References
(Regression)
Details
(Keywords: regression, Whiteboard: [fidefe-MR1-2022])
Attachments
(1 file)
Note
- When the user watches a video in PiP, goes in full screen and hovers over the buttons, he will notice that the buttons don't show a highlight as feedback.
Affected versions
- Nightly v102.0a1
- Beta v101.0b3
- Release
- ESR
Affected platforms
- all
Steps to reproduce
- Launch browser.
- Right-click...
Expected result
- The buttons show slight lighting as feedback on hover.
Actual result
- The buttons don't show any kind of feedback on hover.
Regression range
- Regression:
2022-05-09T16:45:36.356000: DEBUG : Found commit message:
Bug 1707279 Fix picture-in-picture control do not always disappear r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D130838
Additional notes
*
Updated•2 years ago
|
Comment 1•2 years ago
|
||
:shirshak55, since you are the author of the regressor, bug 1707279, could you take a look?
For more information, please visit auto_nag documentation.
Updated•2 years ago
|
I think this behaviour is caused by this css selector. Whenever pip video controls appear, we attach an attribute "showing", which will set 100% opacity for player controls. And with full-screen mode, moving the mouse is one action that attaches this attribute.
We could try setting the button opacity to 80% for full-screen mode when not hovering over a button (like non full-screen mode), even if "showing" is attached:
body:fullscreen #controls[showing]:hover .control-item:not(:hover) {
opacity: 0.8;
}
Updated•2 years ago
|
Assignee | ||
Comment 3•2 years ago
|
||
Hey, I would like to take this up. Thanks!
Updated•2 years ago
|
Assignee | ||
Comment 4•2 years ago
|
||
Pushed by kpatenio@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b136d2f2b267 The PiP's buttons show a highlight on hover when in full screen r=kpatenio,niklas
Comment 6•2 years ago
|
||
bugherder |
Comment 7•2 years ago
|
||
We have a couple of betas left in the 102 cycle, should we uplift this or an it wait 103? Thanks
This doesn't need to be uplifted and can wait. Thanks!
Updated•2 years ago
|
Description
•