Closed Bug 1768202 Opened 2 years ago Closed 2 years ago

The Play/Pause button loses functionality upon opening PiP window for the first time on Netflix

Categories

(Toolkit :: Picture-in-Picture, defect)

Desktop
All
defect
Points:
3

Tracking

()

VERIFIED FIXED
102 Branch
Tracking Status
firefox-esr91 --- unaffected
firefox100 + verified
firefox101 --- verified
firefox102 --- verified

People

(Reporter: ada.cristea, Assigned: niklas)

References

Details

(Keywords: regression, Whiteboard: [fidefe-MR1-2022])

Attachments

(2 files, 1 obsolete file)

Note

  • When the user launches the PiP for the first time in a fresh profile on Netflix, it will display at the very bottom-right edge, presenting four buttons: unPiP, Play/Pause and Mute and Close. If the user chooses to Play/Pause the video by tapping on the button, he will notice that the button has no functionality (stuck).
  • However, the issue will no longer be present after refreshing the page.

Affected versions

  • Nightly v102.0a1
  • Beta v101.0b2
  • Release
  • ESR unaffected

Affected platforms

  • Windows 10 x64
  • Mac OS 11.6 (Big Sur)

Steps to reproduce

  1. Launch browser in a new profile.
  2. Play any video.
  3. Launch the PiP window.
  4. Tap the Play/Pause button.

Expected result

  • The user is able to Play/Pause the video.

Actual result

  • The used is unable to Play/Pause the video.

Regression range

  • This appears to be a regression, however it can't be investigated while the Widevine issue still reproduces. (1767953)

Hmm. I'm not sure what would have regressed this on our side, but it's possible that a change on the site itself has broken what bug 1752132 did. Niklas, would you have the cycles to be able to look at this?

Flags: needinfo?(nbaumgardner)
Assignee: nobody → nbaumgardner
Status: NEW → ASSIGNED

Comment on attachment 9275566 [details]
Bug 1768202 - Get the correct session id from netflix api. r=#pip-reviewers!

Beta/Release Uplift Approval Request

  • User impact if declined: Users are currently unable to play and pause videos on Netflix. With this patch, play and pause work as expected
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: 1. Navigate to Neftlix
  1. Open a PiP window
  2. Confirm that play and pause work from within the PiP window
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Not risky because this only changes the session id used for the Netflix api.
    Picture-in-Picture is currently broken on Netflix so this needs to be uplifted as soon as possible.
  • String changes made/needed: No
  • Is Android affected?: No
Flags: needinfo?(nbaumgardner)
Attachment #9275566 - Flags: approval-mozilla-release?
Attachment #9275566 - Flags: approval-mozilla-beta?
Flags: qe-verify+
Pushed by mhowell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/efeb97393573
Get the correct session id from netflix api. r=pip-reviewers,mhowell
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 102 Branch
Attached file WIP: Bug 1768202 - testing netflix (obsolete) —

Backed out for breaking Picture-in-Picture on Netflix

Backout link: https://hg.mozilla.org/mozilla-central/rev/45d5d174c2016dc94c44308900b285ab04a207b6

Target Milestone: 102 Branch → ---
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Pushed by nbaumgardner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2e4c515c1230
Get the correct session id from netflix api. r=pip-reviewers,mhowell
Attachment #9275602 - Attachment is obsolete: true
Status: REOPENED → RESOLVED
Closed: 2 years ago2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 102 Branch
QA Whiteboard: [qa-triaged]

Hello,

The issue is fixed - verified v.102 on Windows 10 x64 and MacOS 11.6 (Big Sur).

Status: RESOLVED → VERIFIED

Comment on attachment 9275566 [details]
Bug 1768202 - Get the correct session id from netflix api. r=#pip-reviewers!

Approved for 101.0b5.

Attachment #9275566 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Points: --- → 3

Comment on attachment 9275566 [details]
Bug 1768202 - Get the correct session id from netflix api. r=#pip-reviewers!

Approved for 100.0.1

Attachment #9275566 - Flags: approval-mozilla-release? → approval-mozilla-release+
Attached video 2022-05-11-13-31-44.mp4

I can't seem to be able to reproduce this issue on my Windows 10 and Mac OS 11 systems, on Nightly v102.0a1 from 2022-05-06, Beta v101.0b4 or Release v100 (live), so I can't verify this fix.

The reporter says she's reproduced it on Windows 10 in Beta v101.0b4 and wouldn't reproduce in Beta v101.0b5.

Furthermore, regarding the Nightly channel, she's reproduced in a fixed build and could not reproduce in an affected one, among other various results.

After spending a lot of time (with the reporter) attempting to find the real cause of this issue, we could not come up with a clear result. This does not depend on cookies being accepted or not, does not depend on whether the build was installed or just unzipped, standard or custom installation path...

The bug appears to be intermittent and the fix appears to NOT to fix the issue (at least not entirely).

This was initially verified incorrectly so I will revert the general status to "RESOLVED".
Not sure how to address this next. Niklas, do you have any idea what really causes this issue?

Status: VERIFIED → RESOLVED
Closed: 2 years ago2 years ago
Flags: needinfo?(nbaumgardner)

I just tested this an play/pause work for me on both Nightly 102.0a1 and Beta 101.0b5.

The issue I found was that Netflix was giving more than one session id for their player, so for the site adapter we look through all the session ids to find the correct one and use that to initialize the player.

Flags: needinfo?(nbaumgardner)

Downgrading severity considering the small repro rate.

Severity: S2 → S3

Hello,

I will close the issue as verified - fixed, though the situation is intermitent and might reappear.

Status: RESOLVED → VERIFIED
QA Whiteboard: [qa-triaged]
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: