Update sad/happy smiley faces to emoji
Categories
(Firefox :: Settings UI, enhancement)
Tracking
()
Tracking | Status | |
---|---|---|
firefox113 | --- | fixed |
People
(Reporter: amy, Assigned: siya066btit21)
Details
(Keywords: good-first-bug)
Attachments
(5 files)
In bug 1361957 we did a visual refresh of about:preferences which included adding some smile/sad SVG emoticons. Emoji is more widely supported now, so we should update these assets to use emoji font.
Comment 1•2 years ago
|
||
Hey! I would like to work on this issue. Could you please assign it to me?
Comment 2•2 years ago
|
||
Hi, I'm more than happy to fix this problem!
(In reply to Tiya Bansal from comment #1)
Hey! I would like to work on this issue. Could you please assign it to me?
(In reply to chloenanh90 from comment #2)
Hi, I'm more than happy to fix this problem!
Hi Tiya and Chloe,
To be assigned to a bug, we generally prefer if work has already been started; so please submit a patch, and Bugzilla will automatically assign you to the ticket. (If you're concerned about making conflicting patches, I can suggest another bug for either one of you to work on.)
Reporter | ||
Updated•2 years ago
|
Comment 4•2 years ago
|
||
Hey! I want to work on this issue. Can I know where to find the code for about:preferences?
(In reply to Sumagna Das from comment #4)
Hey! I want to work on this issue. Can I know where to find the code for about:preferences?
The code for about:preferences is in browser/components/preferences. But to update the faces, you might have to look at browser/themes/shared/preferences instead.
To have an idea of what kind of changes you might need to make, see this old revision.
Comment 6•2 years ago
|
||
(In reply to Amy Churchwell [:amy] from comment #0)
In bug 1361957 we did a visual refresh of about:preferences which included adding some smile/sad SVG emoticons. Emoji is more widely supported now, so we should update these assets to use emoji font.
Hello Amy, I'm an outreachy applicant and wants to know, that there are already happy and sad emoji, so am i needed to add a totally new type of emoji or change that emoji.
Like intead of 😃 Grinning Face with Big Eyes I can add 😄 Grinning Face with Smiling Eyes?
Comment 7•2 years ago
|
||
Updated•2 years ago
|
Comment 8•2 years ago
|
||
- Update CSS to make use of unicode emoji
- Delete "face" svg files as they are no longer needed
Depends on D143872
Comment 9•2 years ago
|
||
Depends on D144330
Comment 10•2 years ago
|
||
Depends on D144331
Comment 11•2 years ago
|
||
This good-first-bug hasn't had any activity for 2 months, it is automatically unassigned.
For more information, please visit auto_nag documentation.
Updated•2 years ago
|
Reporter | ||
Updated•2 years ago
|
Updated•2 years ago
|
Comment 12•2 years ago
|
||
The following patch is waiting for review from an inactive reviewer:
ID | Title | Author | Reviewer Status |
---|---|---|---|
D143789 | Bug 1761282: Refactored svg emojis to unicode emojis. r=spohl | ajaypheelz | amy: Resigned from review |
:ajaypheelz, could you please find another reviewer?
For more information, please visit auto_nag documentation.
Comment 13•2 years ago
|
||
The bug assignee is inactive on Bugzilla, so the assignee is being reset.
Comment 14•1 year ago
|
||
hello i am an outreachy intern can i be assigned this issue?
Comment 15•1 year ago
|
||
Hello, I am an outreach applicant, I would like to work on this issue.
Comment 16•1 year ago
|
||
Redirect a needinfo that is pending on an inactive user to the triage owner.
:jhirsch, since the bug has recent activity, could you have a look please?
For more information, please visit auto_nag documentation.
Hello Outreachy applicants! I'm pinging our mentors to see if they have bandwidth to add this to the current set of mentored good-first-bugs.
If you haven't yet made contact with any of the active mentors, now would be a good time to say hello on Matrix (at https://chat.mozilla.org/#/room/#outreachy:mozilla.org). See also the Outreachy wiki page for more details: https://wiki.mozilla.org/Outreachy
Comment 18•1 year ago
|
||
Hey all, I'm assigning this to :wangareirungu3 for now. In the event that they are unable to submit a patch I'll reset the assignee / open it up again.
wangareirungu3 if you still want to work on this bug I would recommend taking a look back through the comments here as well as the patches that got submitted but never landed (you can find them in the "Attachments" section). That should give you a good idea of where to get started. You can reach out to me in the #reusable-components channel on Matrix or request information from me using the form below if you have any questions.
Updated•1 year ago
|
Assignee | ||
Comment 19•1 year ago
|
||
(In reply to Hanna Jones [:hjones] from comment #18)
Hey all, I'm assigning this to :wangareirungu3 for now. In the event that they are unable to submit a patch I'll reset the assignee / open it up again.
wangareirungu3 if you still want to work on this bug I would recommend taking a look back through the comments here as well as the patches that got submitted but never landed (you can find them in the "Attachments" section). That should give you a good idea of where to get started. You can reach out to me in the #reusable-components channel on Matrix or request information from me using the form below if you have any questions.
Hello Hanna, seems like the people who have commented above have been inactive for more than 6 days now, if in case this is bug open please do consider assigning it to me. The only other bug I'm currently working on is still in the discussion phase and I don't really have any other bug that I'm actively working on since the last few days seeing as a good number of them are taken. However, I would understand if you would like to assign it to somebody new for a fair chance. Thank you either ways!
Comment 20•1 year ago
|
||
Hey Siya, you can go ahead and get started on this. I'll reassign the bug over to you. Let me know if you have any questions!
Assignee | ||
Comment 21•1 year ago
|
||
Assignee | ||
Comment 22•1 year ago
|
||
Hi Hanna, I submitted a patch a few days ago and have added you as a reviewer. Kindly let me know if there is anything I am supposed to change. Thank you.
Comment 23•1 year ago
|
||
Hey Siya - I just left some comments, let me know if you have questions.
Assignee | ||
Comment 24•1 year ago
|
||
(In reply to Hanna Jones [:hjones] from comment #23)
Hey Siya - I just left some comments, let me know if you have questions.
Hi! I have revised the patch with necessary changes, please let me know if it is okay this time. I'm sorry for pinging you again.
Reporter | ||
Updated•1 year ago
|
Comment 25•1 year ago
|
||
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/23c5b8727ae3 Update sad/happy smiley faces to emoji. r=hjones,settings-reviewers,Gijs
Comment 26•1 year ago
|
||
bugherder |
Description
•