Implement the HTTP priority incremental flag
Categories
(Core :: Networking: HTTP, task, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox101 | --- | fixed |
People
(Reporter: dragana, Assigned: edgul)
References
(Blocks 1 open bug, Regressed 1 open bug)
Details
(Whiteboard: [necko-triaged])
Attachments
(2 files)
HTTP/3 (also the new HTTP/2) priority draft introduces "Incremental" flag.
In necko code, we currently do not have the information needed to decide whether to set that flag. We will need to extend the necko API to set the flag.
Background info:
- class of services flags
- HttpChannelBase implements nsIClassOfService that has methods setClassOfService
- this where the priorities is propagated into neqo.
We need to extend nsIClassOfService to add the "incremental" flag.
|
Assignee | |
Updated•2 years ago
|
|
|
Assignee | |
Comment 1•2 years ago
|
||
|
|
Assignee | |
Comment 2•2 years ago
|
||
Depends on D142694
|
|
Assignee | |
Updated•2 years ago
|
|
||
Updated•2 years ago
|
|
|
||
Updated•2 years ago
|
Pushed by eguloien@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e65d3214649e (WIP) - Implement http priority flag r=necko-reviewers,dragana https://hg.mozilla.org/integration/autoland/rev/b0abbd5936af (WIP) - Implement the http priority incremental flag: added lint fixes and test coverage. Differential Revision: https://phabricator.services.mozilla.com/D142694 r=necko-reviewers,dragana
|
||
Comment 4•2 years ago
|
||
Backed out for causing xpcshell failures in test_http3_prio_disabled_wrap.js
- Backout link
- Push with failures
- Failure Log
- Failure line: TEST-UNEXPECTED-FAIL | netwerk/test/unit_ipc/test_http3_prio_disabled_wrap.js | xpcshell return code: 0
|
|
Assignee | |
Comment 5•2 years ago
|
||
Latest testing failure appears to be from https://bugzilla.mozilla.org/show_bug.cgi?id=1760125
Pushed by eguloien@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3b8ae696d08d (WIP) - Implement http priority flag r=necko-reviewers,dragana https://hg.mozilla.org/integration/autoland/rev/3899920ef9f1 (WIP) - Implement the http priority incremental flag: added lint fixes and test coverage. Differential Revision: https://phabricator.services.mozilla.com/D142694 r=necko-reviewers,dragana
|
||
Comment 7•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/3b8ae696d08d
https://hg.mozilla.org/mozilla-central/rev/3899920ef9f1
|
|
Assignee | |
Comment 8•2 years ago
|
||
Just reiterating here that the test failures that appear to be caused by this implementation are very likely caused by a known issue in the http3 test server, documented here https://bugzilla.mozilla.org/show_bug.cgi?id=1760125.
These appear new because the previously used netwerk/test/unit/test_http3_prio.js was extended into the following tests:
- netwerk/test/unit/test_http3_prio_enabled.js
- netwerk/test/unit/test_http3_prio_disabled.js
- netwerk/test/unit_ipc/test_http3_prio_enabled_wrap.js
- netwerk/test/unit_ipc/test_http3_prio_disabled_wrap.js
Description
•