Expose HDR video support to content
Categories
(Core :: CSS Parsing and Computation, enhancement)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox100 | --- | fixed |
People
(Reporter: jrmuizel, Assigned: bradwerth)
References
Details
(Keywords: dev-doc-complete)
Attachments
(6 files)
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
3.28 KB,
application/zip
|
Details |
YouTube currently uses:
return window.matchMedia('(dynamic-range: high)').matches ||
(window.screen.pixelDepth > 24 &&
window.matchMedia('(color-gamut: p3)').matches);
Since we're only exposing HDR for video, it's a bit of a stretch for us to claim anything that would pass this test. However the draft media queries spec suggests a query, video-dynamic-range that would work well for us.
|
Assignee | |
Comment 2•2 years ago
|
||
This is a stub that only matches "standard" for all platforms.
|
|
Assignee | |
Comment 3•2 years ago
|
||
Depends on D141053
|
|
Assignee | |
Comment 4•2 years ago
|
||
This will need tests, but I'll start with requesting review now.
|
||
Updated•2 years ago
|
|
|
Assignee | |
Comment 5•2 years ago
•
|
||
Strange. [NSScreen screens] gives me one screen, and NSBitsPerPixelFromDepth gets 24 bits from that screen. My same screen in Chrome reports 30 bits which I think is accurate. So there's something going on with how they are detecting the color depth and we may need to do something similar.
|
|
||
Updated•2 years ago
|
|
|
Assignee | |
Comment 6•2 years ago
|
||
This matches Chrome behavior. Our video-dynamic-range media query also relies
on this value being greater than 24 in order to report "high" level support.
Depends on D141056
|
|
Assignee | |
Comment 7•2 years ago
|
||
Depends on D141306
|
|
Assignee | |
Comment 8•2 years ago
|
||
This function always succeeds so there's no reason to maintain an nsresult.
Depends on D141053
|
|
||
Updated•2 years ago
|
|
|
||
Updated•2 years ago
|
Pushed by bwerth@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f16305c6ec83 Part 1: Support media queries for dynamic-range and video-dynamic-range. r=emilio https://hg.mozilla.org/integration/autoland/rev/d35c5648c936 Part 2: Change nsDeviceContext::GetDepth to eliminate the outparam. r=emilio https://hg.mozilla.org/integration/autoland/rev/81e41f7a1ee4 Part 3: Make HDR-capable macOS screens report 30 pixelDepth. r=mstange https://hg.mozilla.org/integration/autoland/rev/785f4c5f719d Part 4: Make macOS declare video-dynamic-range: high with new-enough OS. r=emilio https://hg.mozilla.org/integration/autoland/rev/60a4497fd1f5 Part 5: Update test expectations. r=emilio
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/33329 for changes under testing/web-platform/tests
|
||
Comment 11•2 years ago
|
||
Backed out 5 changesets (Bug 1751217) for causing wpt(Screen-pixelDepth-Screen-colorDepth001.html) and mochitest(test_media_queries.html) failures.
Backout link
Push with failures
Failure Log - wpt8
Failure Log - 4
Upstream PR was closed without merging
|
||
Comment 13•2 years ago
|
||
Pushed by bwerth@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/21e1650b12db Part 1: Support media queries for dynamic-range and video-dynamic-range. r=emilio https://hg.mozilla.org/integration/autoland/rev/277064a1facb Part 2: Change nsDeviceContext::GetDepth to eliminate the outparam. r=emilio https://hg.mozilla.org/integration/autoland/rev/bfa455b8bb1a Part 3: Make HDR-capable macOS screens report 30 pixelDepth. r=mstange https://hg.mozilla.org/integration/autoland/rev/50b6310935d4 Part 4: Make macOS declare video-dynamic-range: high with new-enough OS. r=emilio https://hg.mozilla.org/integration/autoland/rev/f0a4879c9709 Part 5: Update test expectations. r=emilio
|
||
Comment 14•2 years ago
|
||
Backed out for causing failures at dynamic-range.html.
Backout link: https://hg.mozilla.org/integration/autoland/rev/62f290f99410f345e3041e70a9c97c22c9278afc
Failure log: https://treeherder.mozilla.org/logviewer?job_id=372102858&repo=autoland&lineNumber=6689
Upstream PR was closed without merging
|
||
Updated•2 years ago
|
|
|
Assignee | |
Comment 16•2 years ago
|
||
The test verification of Screen-pixelDepth-Screen-colorDepth001.html fails in the same way even without this patch applied, so I'm going to attempt another landing with every issue fixed but that one.
|
|
||
Comment 17•2 years ago
|
||
Pushed by bwerth@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0b741f7f2cbf Part 1: Support media queries for dynamic-range and video-dynamic-range. r=emilio https://hg.mozilla.org/integration/autoland/rev/a271c6ef730b Part 2: Change nsDeviceContext::GetDepth to eliminate the outparam. r=emilio https://hg.mozilla.org/integration/autoland/rev/1b57e65d4d7e Part 3: Make HDR-capable macOS screens report 30 pixelDepth. r=mstange https://hg.mozilla.org/integration/autoland/rev/17c23e78c904 Part 4: Make macOS declare video-dynamic-range: high with new-enough OS. r=emilio https://hg.mozilla.org/integration/autoland/rev/38e81996feb2 Part 5: Update test expectations. r=emilio
|
||
Comment 18•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/0b741f7f2cbf
https://hg.mozilla.org/mozilla-central/rev/a271c6ef730b
https://hg.mozilla.org/mozilla-central/rev/1b57e65d4d7e
https://hg.mozilla.org/mozilla-central/rev/17c23e78c904
https://hg.mozilla.org/mozilla-central/rev/38e81996feb2
|
|
Assignee | |
Updated•2 years ago
|
Upstream PR merged by moz-wptsync-bot
|
||
Comment 20•2 years ago
|
||
Hello, I am updating the MDN docs for dynamic-range and video-dynamic-range.
The issue tracking the doc updates is here: https://github.com/mdn/content/issues/14405
I would appreciate any help with a suitable example to add to the video-dynamic-range page.
|
|
Assignee | |
Comment 21•2 years ago
|
||
(In reply to Dipika from comment #20)
I would appreciate any help with a suitable example to add to the
video-dynamic-rangepage.
Hopefully this is suitable for MDN. The videos are from web-platform-test so they are license unencumbered.
Description
•