Affected versions

• 96.0a1 (20211202215058)
• 95.0 (20211129150630)
• 94.0.2 (20211119140621)

Affected platforms

• Windows10 x64
• macOS 10.15

Preconditions

• OS dark theme enabled

Steps to reproduce

1. Open Firefox with a new profile and go to facebook.com
2. Click on the email or password field.
3. Hover over the Import from options.

Expected result

• Icon from the import form is visible.

Actual result

• Icon from the import from options is barely visible on hover.

Regression range

• Last good revision: 340719f2946c85bb8df494cb4740129e5a5078af
  First bad revision: 6d22ab00f3133b6760ebca3943dba097eff853c7
  Pushlog:
  https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=340719f2946c85bb8df494cb4740129e5a5078af&tochange=6d22ab00f3133b6760ebca3943dba097eff853c7

Notes

• Screen recording attached.
• On 94.0.2 the theme used for the import panel is white so the issue cannot be seen.
• Linux does not have the import function.

Set release status flags based on info from the regressing bug 1734115

Do I need to do something else to get the icon to show up? I don't see that popup at all on a local build.

In any case from looking at the code, this seems like it's using color: GrayText, while the other text for the origin and so on is using opacity: .6;. Perhaps we can just use fill-opacity: .6 instead on the images so they match. WDYT Matt?

(In reply to Emilio Cobos Álvarez (:emilio) from comment #2)

Do I need to do something else to get the icon to show up? I don't see that popup at all on a local build.

You can open Firefox with a new profile and then the popup will be displayed a few times. Unfortunately, I don't know another method.

Mardak would have a better idea about how to enable it but I think you need a login saved for that site in a browser we can import from. You can try to do a manual login import to confirm that the import code is finding the importable login.

You should be able to force the import items to appear with the following in Browser Console:

LoginHelper.suggestImportCount = 3;
LoginHelper.showAutoCompleteImport = "import";
ChromeUtils.import("resource:///modules/ChromeMigrationUtils.jsm").ChromeMigrationUtils.getImportableLogins = () => ["chrome", "chromium-edge", "chromium", "hello world"];

(The first 2 lines override the pref values for signon.suggestImportCount and signon.showAutoCompleteImport.)

It seems like the usual "key" icon chrome://browser/skin/login.svg is also affected by this GrayText-ness?

I think this should be working now.