Closed Bug 1741955 Opened 3 years ago Closed 2 years ago

DoH. "network.trr.mode" pref reverts to 2

Categories

(Core :: Networking: DNS, defect, P3)

Product:
Core
Component:
Networking: DNS
Version:
Firefox 94
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
108 Branch
Tracking Flags:
Tracking Status
firefox94 --- wontfix
firefox95 --- wontfix
firefox96 --- wontfix
firefox108 --- verified

People

(Reporter: loceron780, Assigned: mleclair)

Details

(Whiteboard: [necko-triaged][necko-priority-queue])

Attachments

(1 file)

Bug 1741955: allow value set through about:config for trr mode to precede about:pref r=kershaw
48 bytes, text/x-phabricator-request
Details | Review

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:94.0) Gecko/20100101 Firefox/94.0

Steps to reproduce:

  1. Navigate to "about:config" page and set the "network.trr.mode" pref to 3
  2. Change the DoH provider from settings

Actual results:

The value of the pref changes to 2.

Expected results:

The value of the pref remains set to "3".

Such behavior can provoke DNS leaks.

Also if the "network.trr.mode" is locked to 3 via policies.json, then it's impossible to change the DoH provider from settings' page, the options is grayed out, which is also quite strange.

The Bugbug bot thinks this bug should belong to the 'Firefox::Security' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

Component: Untriaged → Security

Hi Leon,
thank you for taking the time to submit this bug report.
I was able to reproduce on Windows 10, on Firefox Nightly 96.0a1 (2021-11-19) (64-bit) version and Release 94.0.1 (64-bit) version, in the same way as described in steps. I set the flags and severity accordingly.

I let the assigned component in order to get the dev team involved, but if it's not relevant,
'Firefox-Security' team, please feel free to change the component if this is not the appropriate one.
Thanks,
Jerónimo.

Severity: -- → S3
Status: UNCONFIRMED → NEW
status-firefox94: --- → affected
status-firefox95: --- → affected
status-firefox96: --- → affected
Ever confirmed: true
Component: Security → Networking: DNS
Product: Firefox → Core

This should be easy to fix. We just need to check the current value here.

Severity: S3 → S4
Priority: -- → P3
Whiteboard: [necko-triaged][necko-priority-review]
Whiteboard: [necko-triaged][necko-priority-review] → [necko-triaged][necko-priority-queue]
Assignee: nobody → mleclair
Pushed by mleclair@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/400c7fe6d80a
allow value set through about:config for  trr mode to precede about:pref r=kershaw,pbz

https://hg.mozilla.org/mozilla-central/rev/400c7fe6d80a

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox108: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 108 Branch
QA Whiteboard: [qa-108b-p2]

Reproduced with Fx 96.0a1 (2021-11-18) on Windows 10.
Verified fixed with Fx 109.0a1 (2022-11-23) on Windows 10, Ubuntu 22.04 and macOS 12.

Status: RESOLVED → VERIFIED
QA Whiteboard: [qa-108b-p2]
status-firefox108: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: