Use Microsoft Media Foundation H.264 video encoder for WebRTC
Categories
(Core :: WebRTC: Audio/Video, enhancement)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox100 | --- | fixed |
People
(Reporter: jhlin, Assigned: jhlin)
References
Details
Attachments
(6 files)
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review |
Windows s-mode doesn't allow unsigned libraries and could stop us from using OpenH264.
|
Assignee | |
Comment 1•2 years ago
|
||
|
|
Assignee | |
Comment 2•2 years ago
|
||
Depends on D135766
|
|
Assignee | |
Comment 3•2 years ago
|
||
|
|
Assignee | |
Comment 4•2 years ago
|
||
Depends on D137314
|
|
Assignee | |
Comment 5•2 years ago
|
||
Cherry-picked from https://webrtc.googlesource.com/src/+/3791d332c53b283d76d2d3f2fc7e2e74ae28ba1e
Depends on D137315
Pushed by jolin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/77104570d24e p1: support software MFT video encoders. r=alwu,media-playback-reviewers https://hg.mozilla.org/integration/autoland/rev/481fb3a2b3c6 p2: get MPEG header data for only H.264. r=alwu,media-playback-reviewers https://hg.mozilla.org/integration/autoland/rev/492163502bd8 p3: reject simulcast request gracefully. r=alwu https://hg.mozilla.org/integration/autoland/rev/a3782e11e270 p4: return correct VP9 info. r=alwu https://hg.mozilla.org/integration/autoland/rev/84d347955733 p5: proper assignment of FEC setting to encoders in SoftwareFallbackWrapper. r=mjf
|
||
Comment 7•2 years ago
|
||
Backed out for causing high frequency failures at test_capture_throttled.html.
Backout link: https://hg.mozilla.org/integration/autoland/rev/401a0b16caa8198bc53221e2dfb1440cfb9478b6
Failure log: https://treeherder.mozilla.org/logviewer?job_id=369037823&repo=autoland&lineNumber=2986
|
|
Assignee | |
Comment 8•2 years ago
|
||
Initializing platform encoders often takes some time and the frame
rate measured is lower than actual number when the counting starts as
soon as connection established. Delaying the measurement until there
is at least some frame encoded makes it more accurate.
Pushed by jolin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/09598037b0dc p1: support software MFT video encoders. r=alwu,media-playback-reviewers https://hg.mozilla.org/integration/autoland/rev/0778acd1d8e9 p2: get MPEG header data for only H.264. r=alwu,media-playback-reviewers https://hg.mozilla.org/integration/autoland/rev/0b63f292c9f8 p3: reject simulcast request gracefully. r=alwu https://hg.mozilla.org/integration/autoland/rev/b671883b5fc9 p4: return correct VP9 info. r=alwu https://hg.mozilla.org/integration/autoland/rev/7fe7b3011e6f p5: proper assignment of FEC setting to encoders in SoftwareFallbackWrapper. r=mjf https://hg.mozilla.org/integration/autoland/rev/5286475acad3 p6: wait for frame encoded in capture throttle test. r=jib
|
||
Comment 10•2 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/09598037b0dc
https://hg.mozilla.org/mozilla-central/rev/0778acd1d8e9
https://hg.mozilla.org/mozilla-central/rev/0b63f292c9f8
https://hg.mozilla.org/mozilla-central/rev/b671883b5fc9
https://hg.mozilla.org/mozilla-central/rev/7fe7b3011e6f
https://hg.mozilla.org/mozilla-central/rev/5286475acad3
|
||
Comment 11•2 years ago
|
||
(In reply to Pulsebot from comment #9)
Pushed by jolin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/09598037b0dc
p1: support software MFT video encoders. r=alwu,media-playback-reviewers
This patch doesn't sound specific to H264. Is it? If not, maybe rename this bug to more accurately reflect scope?
|
||
Comment 12•2 years ago
|
||
(In reply to Pulsebot from comment #9)
https://hg.mozilla.org/integration/autoland/rev/09598037b0dc
p1: support software MFT video encoders. r=alwu,media-playback-reviewers
Is there a bug filed for removing the early beta condition from this pref?
|
|
Assignee | |
Comment 13•2 years ago
|
||
In bug 1766311, platform encoders were disabled except for Android.
|
|
||
Comment 14•2 years ago
|
||
(In reply to John Lin [:jhlin][:jolin] from comment #13)
In bug 1766311, platform encoders were disabled except for Android.
https://searchfox.org/mozilla-central/source/modules/libpref/init/StaticPrefList.yaml#9629 is the condition I was referring to.
|
|
Assignee | |
Comment 15•2 years ago
|
||
(In reply to Ryan VanderMeulen [:RyanVM] from comment #14)
(In reply to John Lin [:jhlin][:jolin] from comment #13)
In bug 1766311, platform encoders were disabled except for Android.
https://searchfox.org/mozilla-central/source/modules/libpref/init/StaticPrefList.yaml#9629 is the condition I was referring to.
This pref is only in effect when media.webrtc.platformencoder is on.
Description
•