Pref on layout.css.page-size.enabled
Categories
(Core :: CSS Parsing and Computation, enhancement, P3)
Tracking
()
People
(Reporter: alaskanemily, Assigned: alaskanemily)
References
Details
(Keywords: dev-doc-needed)
Attachments
(1 file)
|
48 bytes,
text/x-phabricator-request
|
pascalc
:
approval-mozilla-beta+
|
Details | Review |
|
Assignee | |
Comment 1•3 years ago
|
||
Pushed by emcdonough@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b70cded0d229 Pref on layout.css.page-size.enabled r=dholbert
|
||
Comment 3•3 years ago
|
||
Backed out changeset b70cded0d229 (bug 1738358) for causing wpt failures in /css/css-values/viewport-units-css2-001.
Backout link: https://hg.mozilla.org/integration/autoland/rev/34fbe381ef30e041c18d5f54a96e98bc5fd7609b
Pushed by emcdonough@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/19cf8b8b5895 Pref on layout.css.page-size.enabled r=dholbert
|
|
Assignee | |
Comment 5•3 years ago
|
||
I am pretty certain the failure was a spurious one and not related to my changes. I have tested this in try to check the exact test on the correct platform: https://treeherder.mozilla.org/jobs?repo=try&revision=7814dedadeda22a12ae72121340716de2230f27e&selectedTaskRun=ZAPnEUgvQgqBPW7rLarUig.0
|
|
||
Comment 6•3 years ago
|
||
| bugherder | ||
|
|
Assignee | |
Comment 7•3 years ago
|
||
Comment on attachment 9248324 [details]
Bug 1738358 - Pref on layout.css.page-size.enabled
Beta/Release Uplift Approval Request
- User impact if declined: page-size will not be enabled when printing
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): This change has been in testing in nightly for over a release now. It was only backed out of the release because of a spurious failure that was unrelated to the change.
- String changes made/needed:
|
|
Assignee | |
Comment 8•3 years ago
|
||
Flagging this for beta uplift because it was only backed out during the time the branch was made due to an unrelated, spurious test failure.
|
||
Comment 9•3 years ago
|
||
Comment on attachment 9248324 [details]
Bug 1738358 - Pref on layout.css.page-size.enabled
Approved for 95 beta 3, thanks.
|
|
||
Comment 10•3 years ago
|
||
| bugherder uplift | ||
|
||
Comment 11•2 years ago
|
||
Looks like it is still not documented that this is now on by default. So I'm setting the dev-doc-needed flag.
Emily and others, please help the MDN team by marking new web features with that flag so they know that they need to be documented!
Sebastian
Description
•