Closed Bug 1735526 Opened 3 years ago Closed 3 years ago

Margins selection up/down arrows are not visible on print preview dialog, if you have a large system font size

Categories

(Toolkit :: Printing, defect)

defect

Tracking

()

VERIFIED FIXED
95 Branch
Tracking Status
firefox93 --- wontfix
firefox94 --- wontfix
firefox95 --- verified

People

(Reporter: zstimi, Assigned: emilio)

Details

(Keywords: regressionwindow-wanted)

Attachments

(2 files)

Note

  • Ubuntu 20.04 x64, Windows 10 x64 and macOS 10.15 not affected.

Affected versions

  • Firefox 94.0b5
  • Firefox 95.0a1
  • Firefox 93.0

Affected platforms

  • Ubuntu 16.04 x86

Steps to reproduce

  1. Launch Firefox
  2. Go to any random page (page not PDF (PDFs don't have margins to be set)).
  3. Access the print preview page with Ctrl+ P.
  4. In the new semi-modal printing UI, click on Margins drop-down and select any of the
    displayed options.

Expected result

  • Selecting the Custom value from margins exposes options to modify margins.

Actual result

  • The bottom and right margins could not be modified, because the up and down
    selection arrows are cut off from the print preview page .

Regression range

  • I will come back with regression range ASAP.

Additional notes

  • The issue is reproducible only on Ubuntu 16.04 x86.
  • The issue can be seen in the attachment.
Has STR: --- → yes

I can also reproduce the issue in Nightly84.0a1-95.0a1 Windows10(TEXT scale=140%, DPI scale=100%). (I can scroll the right pane horizontally to see the up/down arrow).
So, it seems not a resent regression.
It seems to depend on the system font size.
The print preview doesn't seem to take system font size into account. Just Fixed Layout :(

OS: Linux → All
QA Whiteboard: [qa-regression-triage]
Summary: [Ubuntu x86] Margins selection are not visible on print preview page → [Ubuntu x86] Margins selection up/down arrows are not visible on print preview page

This looks like a bug in our frontend constraints here; the dialog doesn't account for the possibility that there may be a large font size which might make these input fields wider.

Reclassifying as Toolkit|Printing which I think is where we're tracking frontend bugs in the print preview dialog.

Component: Print Preview → Printing
Product: Core → Toolkit
Hardware: x86 → All
Summary: [Ubuntu x86] Margins selection up/down arrows are not visible on print preview page → Margins selection up/down arrows are not visible on print preview dialog, if you have a large system font size
Version: Firefox 94 → Trunk
Assignee: nobody → emilio
Status: NEW → ASSIGNED
Attachment #9247571 - Attachment description: Bug 1735526 - Make print settings pane width dependent on font size. r=mstriemer → Bug 1735526 - Make print settings custom margins pane have a less fragile layout. r=mstriemer
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dcbcf91ea151
Make print settings custom margins pane have a less fragile layout. r=mstriemer
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch

I can confirm this issue is fixed, I verified using Firefox 95.0a1 (latest nightly) on Ubuntu 16.04 x86, with 1920x1080 resolution and scale for menu and title bars: 1,12 and 1, the arrows are visible in margins settings layout.

I can confirm this issue is fixed, I verified using Firefox 95.0b5 on Ubuntu 16.04 x86, with 1920x1080 resolution and scale for menu and title bars: 1,12 and 1.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: