Affected versions

• Fx 94.0b4
• Fx 95.0a1

Affected platforms

• Windows 10
• Ubuntu 20.04
• macOS 10.15

Steps to reproduce

1. Launch Firefox.
2. Enable one of the colorway themes.
3. Navigate to www.reddit.com and open the Enhanced Tracking Protection panel (ETP).
4. Hover over the 'Why' button.

Expected result

• Same color on hover as on the other elements.

Actual result

• Grey hover animation.

Regression range

• This is not a regression.

We need to specify a different background-color for this element. We can also do a bit of cleanup here. First, we should add #protections-popup-not-blocking-section-why:hover and #protections-popup-not-blocking-section-why:hover:active here. However, those rules are being overridden by these ones. The second ones are more correct, so we should move the background-color: var(--panel-item-hover-bgcolor); and var(--panel-item-active-bgcolor) up to the first block, replacing background-color: var(--arrowpanel-dimmed) and var(--arrowpanel-dimmed-further). Then we can delete the second set of rules.

@Harry I am an Outreachy applicant. Can I work on these issue? Thank you.(In reply to Harry Twyford [:harry] from comment #1)

Certainly! First, get your development environment set up with the Quick Reference. Then, follow my instructions in comment 1. Please let me know if you encounter any issues.

@Harry, Hi ,

On setting up firefox using the Quick Reference guide link. I have successfully cloned the repository, but On running this command: $ ./mach bootstrap, I got the option to choose the version of firefox I want build. I selected the first one according to the instruction. But I am getting the following errors.
Please can you assist me on what to do to resolve the error below.
Hoping to hear from you soon. Thanks.

Error: The following directories are not writable by your user:
/usr/local/share/man/man5
/usr/local/share/man/man8

You should change the ownership of these directories to your user.
sudo chown -R $(whoami) /usr/local/share/man/man5 /usr/local/share/man/man8

And make sure that your user has write permission.
chmod u+w /usr/local/share/man/man5 /usr/local/share/man/man8
Error running mach:

['bootstrap']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.
You can invoke |./mach busted| to check if this issue is already on file. If it
isn't, please use |./mach busted file bootstrap| to report it. If |./mach busted| is
misbehaving, you can also inspect the dependencies of bug 1543241.

Have you tried changing the permissions as it recommends? i.e. running

sudo chown -R $(whoami) /usr/local/share/man/man5 /usr/local/share/man/man8
chmod u+w /usr/local/share/man/man5 /usr/local/share/man/man8

@Harry, I have finally resolved the error. I ran the following command

sudo chown -R $(whoami) /usr/local/share/man/man5
sudo chown -R $(whoami) /usr/local/share/man/man8

After that I re-run this command $ ./mach bootstrap,

Everything worked perfectly well. I have succeed in launching Firefox. Thank you.

Time to fix the issue.

@Harry, I have seen the ETP after navigating to www.reddit.com. I can't find the 'why' button. Please can you give me some guidelines. Thank you.

The why button is here.

@Harry, I have fixed the bug. Please check the screenshot. I want to make a pull request. Thank you.

@ Harry, I have finally solved the issue. Please what is the next step or should I go ahead and make a pull request? Thank you.

@Harry, I have finally committed my changes to the Phabricator following the "Quick reference" guide.

Here is the Url

https://phabricator.services.mozilla.com/D128518

Hope everything is ok as expected.

Thank you for your help. Hope to hear from you soon.

@Harry, Please I noticed the white spaces I created while fixing the bug . I want to correct it by removing the white spaces. I also want to add your name as the reviewer but when I did, I got this error. Please can you tell me the right thing to do? Thank you.

Bug 1735163 - Changed the color of the 'Why' button from the ETP panel from grey to the required color based on the instruction given. r?harry
zsh: no matches found: r?harry

and also removed white spaces

:w
:q

:w
:q
:q

Depends on D128518

Depends on D128643

Depends on D128644

When changing an existing commit, please use hg commit --amend so that you're only submitting a single patch. Refer to this section of the QuickReference.

So the workflow would be

<make a change>
$ hg commit --amend
<update commit message, if necessary>
$ moz-phab

(In reply to onuohamiriam44 from comment #13)

@Harry, Please I noticed the white spaces I created while fixing the bug . I want to correct it by removing the white spaces. I also want to add your name as the reviewer but when I did, I got this error. Please can you tell me the right thing to do? Thank you.

Bug 1735163 - Changed the color of the 'Why' button from the ETP panel from grey to the required color based on the instruction given. r?harry
zsh: no matches found: r?harry

The commit message should be typed in after you call hg commit, not directly into your shell.

@Harry. Thank you so much. I have removed the white spaces and commented codes. Please check it out. Is it ok?

You've posted four patches instead of one. Could you please go to Phabricator, scroll to the bottom of the page, and select "Abandon Revision" on all the ones you don't need reviewed?

This is the link https://phabricator.services.mozilla.com/D128643

I have (In reply to Harry Twyford [:harry] from comment #19)

You've posted four patches instead of one. Could you please go to Phabricator, scroll to the bottom of the page, and select "Abandon Revision" on all the ones you don't need reviewed?

I have done it. Is there still a mistake? Please don't be offended with me. Thank you.

@Harry, Good morning. Hope your weekend was cool? I have selected "Abandon Revision" for the three I don't want and left only one. This is the link of the one I want. Thank you.

Hope to hear from you.

https://phabricator.services.mozilla.com/D128643

https://hg.mozilla.org/mozilla-central/rev/1e1763e43db4

Is this something we want to uplift for the Fx94 RC or can it ride the trains? Please nominate ASAP if you want to uplift.

This can ride the trains.

I have reproduced this issue using Firefox 94.0b4 on Win 10 x64.
I can confirm this issue is fixed, I verified using Firefox 95.0b2 on Win 10 x64, macOS 10.15 and Ubuntu 20.04 x64.