Closed
Bug 1734347
Opened 3 years ago
Closed 3 years ago
[Monochrome Themes][Cheers-Balanced] The field for Search is not visible while it's inside the Overflow Menu
Categories
(Firefox :: Theme, enhancement, P3)
Firefox
Theme
Tracking
()
People
(Reporter: obotisan, Assigned: bugzilla)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
60.56 KB,
image/png
|
Details | |
48 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details | Review |
Affected versions
- Firefox 95.0a1
- Firefox 94.0b2
Affected platforms
- macOS 10.15
- Windows 10 x64
- Ubuntu 18.04 x64
Preconditions
- Select Cheers-Balanced Theme.
Steps to reproduce
- Go to Application menu -> More tools -> Customize toolbar... and drag the "Search" icon in the Overflow menu.
- In a new tab click on the "More tools..." button.
Expected result
- The border for the Search field is visible.
Actual result
- The field is not visible.
Regression range
- Not a regression.
Additional notes
- The color from the Cheers-Bold can be used here.
Assignee | ||
Updated•3 years ago
|
Assignee: nobody → htwyford
Status: NEW → ASSIGNED
Iteration: --- → 95.1 - Oct 4 - Oct 17
Points: --- → 1
Priority: -- → P3
Assignee | ||
Comment 1•3 years ago
|
||
Pushed by htwyford@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2da217cce0c4 Improve appearance of searchbar in overflow panel. r=dao
Comment 3•3 years ago
|
||
Comment on attachment 9244640 [details]
Bug 1734347 - Improve appearance of searchbar in overflow panel. r?dao!
Beta/Release Uplift Approval Request
- User impact if declined: In the new "Cheers - Balanced" colorway theme, the field for Search is not visible while it's inside the Overflow Menu. This makes that theme more accessible.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): CSS-only change.
- String changes made/needed:
Attachment #9244640 -
Flags: approval-mozilla-beta?
Comment 4•3 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 95 Branch
Comment 5•3 years ago
|
||
Comment on attachment 9244640 [details]
Bug 1734347 - Improve appearance of searchbar in overflow panel. r?dao!
Approved for 94.0b4.
Attachment #9244640 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 6•3 years ago
|
||
bugherder uplift |
Updated•3 years ago
|
Flags: qe-verify+
Updated•3 years ago
|
QA Whiteboard: [qa-triaged]
Reporter | ||
Comment 7•3 years ago
|
||
Verified the fix using Windows 10 x64, macOS 10.15 and Ubuntu 18.04 on Firefox 94.0b4 and Firefox 95.0a1. The issue is not reproducing anymore.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in
before you can comment on or make changes to this bug.
Description
•