Affected versions

• 94.0a1 (20211001093323)

Affected platforms

• Windows 10 x64
• macOS 10.15
• Ubuntu 21.04

Preconditions

• Dark theme

Steps to reproduce

1. Open Firefox and a new tab.
2. Click on the Edit this site option from the Top site's category.

Expected result

• Image field is visible.

Actual result

• Grey background with the Grey image field.

Regression range

• Last good revision: 462b8ab0d119d85c044a1332446b609786fcabc7
  First bad revision: 4d1d81ae7b7edc5668d65b6927d907feab8d0e21
  Pushlog:
  https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=462b8ab0d119d85c044a1332446b609786fcabc7&tochange=4d1d81ae7b7edc5668d65b6927d907feab8d0e21

Notes

• Attached a screenshot.

We need a rule in this block targeting the top site tile in the Edit Top Sites modal. It's .top-site-inner > .top-site-button > .tile. border: 1px solid var(--newtab-border-color) looks good.

If a contributor works on this, note that you will have to bundle the CSS before you can see your changes. Run ./mach npm run bundle --prefix=browser/components/newtab. More information here.

Hi everyone, I'm interested in working on this issue.
I'm new to bugzilla would appreciate resources on next steps! Thank you!

(In reply to secret.okra-0z from comment #2)

Hi everyone, I'm interested in working on this issue.
I'm new to bugzilla would appreciate resources on next steps! Thank you!

Hello and welcome to bugzilla!
You are welcome to work on this issue. We're happy to answer any questions that come up.

In terms of next steps: have you been able to get the Firefox codebase set up on your computer? Some useful information can be found here if not: https://firefox-source-docs.mozilla.org/setup/index.html

I have not — I'll read and work through setup over the weekend!

Thank you for the resource!

Set release status flags based on info from the regressing bug 1727319

(In reply to Amy Churchwell [:amy] from comment #3)

(In reply to secret.okra-0z from comment #2)

Hi everyone, I'm interested in working on this issue.
I'm new to bugzilla would appreciate resources on next steps! Thank you!

Hello and welcome to bugzilla!
You are welcome to work on this issue. We're happy to answer any questions that come up.

In terms of next steps: have you been able to get the Firefox codebase set up on your computer? Some useful information can be found here if not: https://firefox-source-docs.mozilla.org/setup/index.html

Hi Amy, I have the codebase set up now! Looking forward to next steps.

That's great! Harry points out the code block to update in comment 1 along with the command to run to see your CSS changes that affect the new tab page.

I like to combine it with ./mach run each time I edit something so I don't forget to bundle it:
./mach npm run bundle --prefix=browser/components/newtab && ./mach run

More info about that is in the new tab page docs here.

You can find the quick reference on how to submit a patch here.

Thanks for your help and feel free to ask questions in this bug or on Matrix, if you'd like. The #introduction channel is a welcoming place.

Ok I will do that! Thank you!

https://hg.mozilla.org/mozilla-central/rev/6c078da0ec50

Please nominate the patch for Beta approval so we can avoid shipping this new regression in Fx94.

Comment on attachment 9246476 [details]
Bug 1733574 - Increase visibility of shortcut image field for dark theme. r?harry

Beta/Release Uplift Approval Request

• User impact if declined: Low-contrast element in the new tab page.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): One-line CSS change.
• String changes made/needed:

Comment on attachment 9246476 [details]
Bug 1733574 - Increase visibility of shortcut image field for dark theme. r?harry

Approved for 94.0rc1.

https://hg.mozilla.org/releases/mozilla-beta/rev/14954a58d67a

Verified fixed with Firefox 95.0a1 (20211024212641) on Windows 10x64, macOS 10.15 and Ubuntu 21.04. The New shortcut image field has a border and can be seen as expected.

Verified fixed with 94.0 (20211025220926) on Windows 10x64, macOS 10.15 and Ubuntu 21.04.