Closed Bug 1732450 Opened 3 years ago Closed 3 years ago

[Monochromatic Themes] The search suggestions hover does not respect the theme color

Categories

(Firefox :: Theme, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED WONTFIX
Tracking Status
firefox94 --- affected

People

(Reporter: cbaica, Unassigned)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Attached image grey hover color

Affected versions

  • Fx94.0a1

Affected platforms

  • Windows 10
  • Ubuntu 20.04
  • macOS 10.15

Preconditions
browser.theme.temporary.monochromatic.enabled = true
Select a monochromatic theme e.g. Lush - Bold
Search bar is enabled from preferences.

Steps to reproduce

  1. Launch Firefox.
  2. Click on the address bar and type a word.
  3. Hover the mouse over the suggestions.
  4. Click on the search bar and type a word.
  5. Hover over the suggestions.

Expected result

  • The hover animation (color) is similar to the selected theme or a nuance of the selected theme.

Actual result

  • The hover color is grey.

Regression range

  • Not a regression.

Additional notes

  • Before we had different shades of grey for selection / hover. The behavior should be kept moving forward. For example, the keyboard selection is a lighter shade of the selected theme, but hover is grey. The color difference is very visible in themes that have the address bar dropdown with a white background.
  • This also applies to hovering over items in the sidebar panel.
  • This is similar to the ETP hover issue.
Has STR: --- → yes

This is expected. We let themes customize the selected result color with the popup_highlight property. Hover color is the same as the color used in secondary buttons. We have no plans to change this, so I'm going to close this bug.

(In reply to Cristian Baica [:cbaica], Release Desktop QA from comment #0)

  • Before we had different shades of grey for selection / hover. The behavior should be kept moving forward. For example, the keyboard selection is a lighter shade of the selected theme, but hover is grey. The color difference is very visible in themes that have the address bar dropdown with a white background.

This isn't entirely true. Dark theme uses a blue-ish black color for keyboard selection and a light grey for hover. The selection color takes after the theme, but the hover color does not.

Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: