Closed Bug 1732291 Opened 3 years ago Closed 3 years ago

[Monochromatic Themes] The focused link listed inside the Sidebar is hard to see while using a Balanced Theme

Categories

(Firefox :: Theme, defect, P2)

Product:
Firefox
Component:
Theme
Version:
Firefox 94
Platform:
All
macOS
Type:
defect
Points:
1

Tracking

()

Status:
VERIFIED FIXED
Tracking Flags:
Tracking Status
firefox94 --- verified
firefox95 --- verified

People

(Reporter: obotisan, Assigned: bugzilla)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fidefe-theme])

Attachments

(1 file, 1 obsolete file)

Screenshot 2021-09-23 at 11.54.26.png
628.57 KB, image/png
Details

Affected versions

  • Firefox 94.0a1

Affected platforms

  • macOS 10.15

Preconditions

  • browser.theme.temporary.monochromatic.enabled = true
  • Select one the Grafitti Balanced theme.

Steps to reproduce

  1. Go to Application menu -> More tools -> Customize toolbar... and drag the "Show sidebars" button on the Toolbar.
  2. Click on one of the listed sites.

Expected result

  • The contrast between the link and the focus is higher and the text can be read.

Actual result

  • The contrast makes it hard to read the text.

Regression range

  • Not a regression.

Additional notes

  • All the Balanced themes are effected except Elemental and Cheers.
OS: All → macOS
Has STR: --- → yes
Whiteboard: [fidefe-theme]

Sidebar highlights were not getting the correct background color because we didn't also specify sidebar_highlight_text.

Assignee: nobody → htwyford
Status: NEW → ASSIGNED

Comment on attachment 9243569 [details]
Bug 1732291 - Populate sidebar_highlight_text. r?amy!

Revision D127003 was moved to bug 1732090. Setting attachment 9243569 [details] to obsolete.

Attachment #9243569 - Attachment is obsolete: true
Points: --- → 1
Priority: -- → P2

This is fixed in the patch for bug 1732090.

Depends on: 1732090

Sorry, I meant bug 1732322.

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox95: --- → fixed
Depends on: 1732322
No longer depends on: 1732090
Resolution: --- → FIXED

Verified the fix using Firefox 94.0b2 and Firefox 95.0a1 on macOS 10.15. The issue is not reproducing anymore.

Status: RESOLVED → VERIFIED
status-firefox94: fixed → verified
status-firefox95: fixed → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: