The downloads panel button breaks if we try to open it automatically while customize mode is open
Categories
(Firefox :: Downloads Panel, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr78 | --- | unaffected |
firefox-esr91 | --- | unaffected |
firefox92 | --- | unaffected |
firefox93 | --- | wontfix |
firefox94 | --- | wontfix |
firefox95 | --- | wontfix |
firefox96 | --- | wontfix |
firefox97 | --- | verified |
firefox98 | --- | verified |
People
(Reporter: cbaica, Assigned: Gijs)
References
(Regression)
Details
(Keywords: regression, Whiteboard: [fidefe-mr11-downloads])
Attachments
(2 files)
1.51 MB,
video/mp4
|
Details | |
48 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details | Review |
Affected versions
- Fx94.0a1
- Fx93.0b8
Affected platforms
- Windows 10
- Ubuntu 20.04
- macOS 10.14
Steps to reproduce
- Launch Firefox.
- Navigate to thinkbroadband.com/download and download the 5mb file.
- Click 'ok' in the action prompt and then click on the download panel.
- Click on the 5mb file again.
- While the actions prompt is open, right click the toolbar.
- Open the Customize toolbar page.
- While the customize toolbar page is open, click the 'ok' button to save the file.
- Click 'done' in the customize page.
- Click the download button, to open the panel.
Expected result
- The download panel is opened on click.
Actual result
- The download panel doesn't open.
Regression range
- Will come back with a regression range ASAP.
Additional notes
- The issue occurs if another download operation was done in that session. The issue never occurs for the first download of a section.
- Pressing CTRL+J opens the download library as well as the download panel, making it functional again. If the issue is reproduced again, this workaround no longer works (download panel button will remain broken).
- The issue happened randomly while trying to reproduce it using a google drive download (this file was used during investigation).
Reporter | ||
Comment 1•3 years ago
|
||
Regression range took me to this pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=074c9b0a8e7745d593ccd9efc909ce6787dd4fc2&tochange=02e1e9b5931a2a09086e3ecd1abc85f9969cc30f
Reporter | ||
Updated•3 years ago
|
Reporter | ||
Updated•3 years ago
|
Updated•3 years ago
|
Comment 2•3 years ago
•
|
||
This looks like an edge case, with the simple workaround to restart the browser, I assume. But it would still be annoying if it happens to a user, so we should look into it.
Sebastian, would you have time to look into why your change caused this?
Off-hand it looks like the usual problem with Customize mode removing and reinserting the widget on the toolbar.
Comment 3•3 years ago
|
||
Set release status flags based on info from the regressing bug 1676221
Updated•3 years ago
|
Updated•2 years ago
|
Assignee | ||
Comment 4•2 years ago
|
||
The bug says 91 is affected but 92 is not. Can you doublecheck if 91esr is affected?
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Comment 5•2 years ago
|
||
Both for minimized windows and if there is no anchor, we bail out from showing the panel.
However, only one of those cases currently resets the internal state flag to 'hidden'.
This patch ensures both cases do so, and for good measure ensures that if openPopup
throws (which apparently it can?) we also reset the state in that case, rather than
leaving ourselves with a permanently broken state.
Updated•2 years ago
|
Pushed by gijskruitbosch@gmail.com: https://hg.mozilla.org/integration/autoland/rev/329e5b9ac83e don't allow customize mode to permanently break the downloads button in a window, r=mhowell
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Updated•2 years ago
|
Updated•2 years ago
|
Comment 7•2 years ago
|
||
bugherder |
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Comment 8•2 years ago
|
||
Comment on attachment 9260500 [details]
Bug 1732129 - don't allow customize mode to permanently break the downloads button in a window, r?mhowell
Beta/Release Uplift Approval Request
- User impact if declined: Completely broken downloads panel in some edgecases (x-ref also bug 1750628 which we're hoping will be fixed by this)
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: See comment 0 (now requires setting
browser.download.improvements_to_download_panel
to false) - List of other uplifts needed: Bug 1741076, Bug 1731710
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Minor changes to the logic around showing the downloads panel that ensure consistent state, with good automated test coverage and sufficient beta runway at this point
- String changes made/needed: None
Assignee | ||
Updated•2 years ago
|
Comment 9•2 years ago
|
||
Comment on attachment 9260500 [details]
Bug 1732129 - don't allow customize mode to permanently break the downloads button in a window, r?mhowell
Approved for 97.0b9.
Comment 10•2 years ago
|
||
bugherder uplift |
Updated•2 years ago
|
Comment 11•2 years ago
|
||
Reproduced the initial issue on Firefox 97 beta 8 on macOS Big Sur 11.6.
Verified as fixed using the latest Nightly 98.0a1 on macOS Big Sur 11.6, Ubuntu 20.04 x64, and Windows 10 x64.
Comment 12•2 years ago
|
||
Verified as fixed using Firefox 97 Beta 9 on Windows 10, macOS Big Sur 11.6, Ubuntu 20.04.
Description
•