Closed
Bug 1732093
Opened 3 years ago
Closed 3 years ago
[Monochromatic Themes] hover/active colors inside ETP panel doesn't respect the theme colors.
Categories
(Firefox :: Theme, defect)
Tracking
()
VERIFIED
FIXED
94 Branch
| Tracking | Status | |
|---|---|---|
| firefox94 | --- | verified |
People
(Reporter: obotisan, Assigned: amy)
References
(Blocks 1 open bug)
Details
(Whiteboard: [fidefe-theme])
Attachments
(1 file)
Affected versions
- Firefox 94.0a1
Affected platforms
- macOS 10.15
- Windows 10 x64
- Ubuntu 20.04 x64
Preconditions
- browser.theme.temporary.monochromatic.enabled = true
- Select one the Monochromatic themes.
Steps to reproduce
- Go to this site and click on the shiled icon from the Url bar.
- Hover the elements listed.
Expected result
- The hover effect respects the theme colors.
Actual result
- The hover effect is grey.
Regression range
- Not a regression.
Additional notes
- This happens in the Download panel as well.
|
Reporter | |
Updated•3 years ago
|
Summary: [Monochromatic Themes] The hover effect inside ETP panels doesn't respect the theme colors. → [Monochromatic Themes] The hover effect inside ETP panel doesn't respect the theme colors.
|
||
Comment 1•3 years ago
|
||
I'm combining this with bug 1732092.
Summary: [Monochromatic Themes] The hover effect inside ETP panel doesn't respect the theme colors. → [Monochromatic Themes] hover/active colors inside ETP panel doesn't respect the theme colors.
|
Assignee | |
Updated•3 years ago
|
Assignee: nobody → achurchwell
|
||
Updated•3 years ago
|
Whiteboard: [fidefe-theme]
|
|
||
Updated•3 years ago
|
|
|
Assignee | |
Updated•3 years ago
|
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 3•3 years ago
|
||
|
||
Updated•3 years ago
|
Attachment #9243145 -
Attachment description: Bug 1732093 - Apply hover/active theme colors to ETP and downloads panel. r=harry! → Bug 1732093 - Apply hover/active theme colors to ETP and downloads panel. r?harry
Pushed by achurchwell@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9036665f068d Apply hover/active theme colors to ETP and downloads panel. r=harry,desktop-theme-reviewers
|
||
Comment 5•3 years ago
|
||
Backed out for causing failures in browser_parsable_css.js.
Backout link: https://hg.mozilla.org/integration/autoland/rev/6b787be4898dd6467582f91dfabc93fa93af1092
Failure log: https://treeherder.mozilla.org/logviewer?job_id=352979905&repo=autoland&lineNumber=3751
Flags: needinfo?(achurchwell)
Pushed by achurchwell@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/926f7ca67280 Apply hover/active theme colors to ETP and downloads panel. r=harry,desktop-theme-reviewers
|
||
Comment 7•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 94 Branch
|
|
Assignee | |
Updated•3 years ago
|
Flags: needinfo?(achurchwell)
|
||
Updated•3 years ago
|
Flags: qe-verify+
|
|
Reporter | |
Comment 8•3 years ago
|
||
We verified the fix using Firefox 94.0b2 on Windows 10 x64, macOS 10.15 and Ubuntu 18.04 x64. The issue is not reproducing anymore.
You need to log in
before you can comment on or make changes to this bug.
Description
•