Affected versions

• latest Nightly 94.0a1
• Beta 93.0b7

Affected platforms

• Win 10 x64
• Ubuntu 20.04 x64
• macOS 11

Preconditions

• Firefox Dark or Alpenglow theme is applied

Steps to reproduce

1. Navigate to https://www.thinkbroadband.com/download.
2. Download the 50 MB sample file from the test page.
3. Click on the download icon from the toolbar.
4. Click on the download item in order to open the sub panel.

Expected result

• The warning icon has a strong red contrast. It has the same contrast as displayed in the main panel.

Actual result

• The warning icon has a light red contrast.

Suggested Severity

• S3, since this won't affect the functionally.

Regression range

• Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=24c9b17fd62309104[…]a1acc418ce7&tochange=86dd58a44d200bf475d6f39dbe7ecfca4fac41a6
• Potential regressor: Bug 1715001

Additional notes

• The issue does not reproduce with Light theme, it can be only reproduced with the themes written above.

Hi Gijs! Mozregression points out to bug 1715001, as the regressor. Is this something that indeed regressed from bug 1715001, could you please take a look?

Can you provide a screenshot of the comparison, and the pre-patch state? As it is, I'm not sure whether this is a problem. I don't think there was an intentional change, but OTOH there's no spec for dark mode and these icons.

(In reply to :Gijs (he/him) from comment #2)

Can you provide a screenshot of the comparison, and the pre-patch state? As it is, I'm not sure whether this is a problem. I don't think there was an intentional change, but OTOH there's no spec for dark mode and these icons.

This screenshot comparation is from Beta 93.0b8: https://drive.google.com/file/d/1ZM1YhSTLUQV5HCDs4cBqWLEh-GttPlJU/view?usp=sharing
This is from Nightly 93.0a1, (20210902092450) before the patch from bug 1715001: https://drive.google.com/file/d/1d_x42WjMhqCv6STeliAbG2ok1X6yEQvx/view?usp=sharing

(In reply to Ciprian Georgiu [:ciprian_georgiu], Release Desktop QA from comment #3)

(In reply to :Gijs (he/him) from comment #2)

Can you provide a screenshot of the comparison, and the pre-patch state? As it is, I'm not sure whether this is a problem. I don't think there was an intentional change, but OTOH there's no spec for dark mode and these icons.

This screenshot comparation is from Beta 93.0b8: https://drive.google.com/file/d/1ZM1YhSTLUQV5HCDs4cBqWLEh-GttPlJU/view?usp=sharing
This is from Nightly 93.0a1, (20210902092450) before the patch from bug 1715001: https://drive.google.com/file/d/1d_x42WjMhqCv6STeliAbG2ok1X6yEQvx/view?usp=sharing

I don't appear to have access rights for either of these, so I can't see them... can you give me those or attach to bugzilla? :-)

Sorry, my bad. I forgot to properly add the sharing rights. Can you please try again, it should work now.

Thanks, that works!

Although the download panel has no dark mode spec, the info bar one has the icons appearing like this, so I think the sub panel one (the lighter version) is correct - we should be using #FF9AA2, also in the main panel.

This is a 1-character typo in a CSS file so I might as well request uplift...

https://hg.mozilla.org/mozilla-central/rev/6911439caf3b

Did you mean to request uplift on this still? We'd be talking an RC ride-along candidate at this point, fwiw.

(In reply to Ryan VanderMeulen [:RyanVM] from comment #12)

Did you mean to request uplift on this still? We'd be talking an RC ride-along candidate at this point, fwiw.

Oh, bother, this slipped through. I can request it but I don't think it's the end of the world. If we're doing RC respins then I guess this can ride-along...

Comment on attachment 9242417 [details]
Bug 1731774 - fix download blocked badge colour in dark themes, r?mtigley

Beta/Release Uplift Approval Request

• User impact if declined: Mismatched colour in downloads panel
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See comment 0
• List of other uplifts needed: n/a
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Literally 1-character change in a CSS file because I'm a dummy.
• String changes made/needed: Nope

Comment on attachment 9242417 [details]
Bug 1731774 - fix download blocked badge colour in dark themes, r?mtigley

Would be landing on release at this point if we uplift to 93.

Verified as fixed this issue on latest Nightly 94.0a1 across platforms: Win 11, macOS 11 and Ubuntu 18.04 x64.