Closed Bug 1731210 Opened 3 years ago Closed 1 year ago

pdf.js modal for unsaved data on a pdf page appears twice in private window

Categories

(Core :: DOM: Security, defect, P1)

Product:
Core
Component:
DOM: Security
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
110 Branch
Tracking Flags:
Tracking Status
firefox-esr78 --- unaffected
firefox-esr91 --- wontfix
firefox-esr102 --- wontfix
firefox92 --- wontfix
firefox93 --- wontfix
firefox94 --- wontfix
firefox95 --- wontfix
firefox96 --- wontfix
firefox97 --- wontfix
firefox98 --- wontfix
firefox108 --- wontfix
firefox109 --- wontfix
firefox110 --- fixed

People

(Reporter: bmaris, Assigned: t.yavor)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression, Whiteboard: [domsecurity-active])

Attachments

(1 file)

Bug 1731210 - pdf.js modal for unsaved data on a pdf page appears twice in private window r=smaug
48 bytes, text/x-phabricator-request
Details | Review

Affected versions

  • Firefox 92.0 RC
  • Firefox 93.0b6
  • Latest Nightly 94.0a1

Affected platforms

  • Ubuntu 18.04
  • Windows 10 64bit
  • MacOS 11.5

Steps to reproduce

  1. Start Firefox
  2. Open a private window
  3. Visit http://foersom.com/net/HowTo/data/OoPdfFormExample.pdf
  4. Enter any data in any field
  5. Refresh the page
  6. Click leave page on the modal that opens

Expected result

  • Page is refreshed

Actual result

  • The modal appears a second time with the same message.

Regression range

Suggested severity

  • I added an S3 severity since it only reproduces in private window.
Flags: needinfo?(ckerschb)
Has Regression Range: --- → yes
Has STR: --- → yes

Tomer, can you take a look please?

Flags: needinfo?(ckerschb) → needinfo?(lyavor)

Sure,
I am on it.

Flags: needinfo?(lyavor)
Assignee: nobody → lyavor
Status: NEW → ASSIGNED
Priority: -- → P1
Whiteboard: [domsecurity-active]

Tomer, any news?

status-firefox93: fix-optional → wontfix
status-firefox95: --- → affected
Flags: needinfo?(lyavor)

I won't fix it for this cycle probably.

Flags: needinfo?(lyavor)
Flags: needinfo?(lyavor)

I am planning to fix it for the upcoming cycle

Flags: needinfo?(lyavor)

:Tomer any update on this?

status-firefox96: affected → wontfix
status-firefox97: --- → affected
Flags: needinfo?(lyavor)

Sorry for being late..
I am on it but I had to delay it for some higher prioritized bugs

Flags: needinfo?(lyavor)

Tomer, do you know what fixed this? Could you find the fix with mozregression?

Sorry I was wrong. My bad.
It is partly fixed.
So the part where you click on refresh is fixed. I didn't find a bug number or patch for that yet.

The bug still occurs if you enter data into the http pdf and then navigate to different url.

I will try to find a general fix for both part. Such that this bug is independent from fixes/ changes that were made.

That patch had fix the reload by user gesture: https://hg.mozilla.org/integration/autoland/rev/853d982bb4cff4f20450db3ce9a9bfa367d09eb8.
Reloads via url bar or navigation to other sites are still leading to two message

Depends on: 1742899
Attachment #9288317 - Attachment description: Bug 1731210 - pdf.js modal for unsaved data on a pdf page appears twice in private window r=evilpie → WIP: Bug 1731210 - pdf.js modal for unsaved data on a pdf page appears twice in private window r=evilpie
Attachment #9288317 - Attachment description: WIP: Bug 1731210 - pdf.js modal for unsaved data on a pdf page appears twice in private window r=evilpie → Bug 1731210 - pdf.js modal for unsaved data on a pdf page appears twice in private window r=evilpie
Attachment #9288317 - Attachment description: Bug 1731210 - pdf.js modal for unsaved data on a pdf page appears twice in private window r=evilpie → Bug 1731210 - pdf.js modal for unsaved data on a pdf page appears twice in private window r=smaug
Attachment #9288317 - Attachment description: Bug 1731210 - pdf.js modal for unsaved data on a pdf page appears twice in private window r=smaug → Bug 1731210 - pdf.js modal for unsaved data on a pdf page appears twice in private window r=evilpie
Blocks: 1789260
Attachment #9288317 - Attachment description: Bug 1731210 - pdf.js modal for unsaved data on a pdf page appears twice in private window r=evilpie → Bug 1731210 - pdf.js modal for unsaved data on a pdf page appears twice in private window r=smaug
Pushed by opettay@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/426e74dbe01e
pdf.js modal for unsaved data on a pdf page appears twice in private window r=smaug

Backed out for causing lint failure on browser_beforeunload_permit_http.js

Backout link

Push with failures

Failure log

Flags: needinfo?(lyavor)
Flags: needinfo?(lyavor)
Attachment #9288317 - Attachment description: Bug 1731210 - pdf.js modal for unsaved data on a pdf page appears twice in private window r=smaug → WIP: Bug 1731210 - pdf.js modal for unsaved data on a pdf page appears twice in private window r=smaug
Attachment #9288317 - Attachment description: WIP: Bug 1731210 - pdf.js modal for unsaved data on a pdf page appears twice in private window r=smaug → Bug 1731210 - pdf.js modal for unsaved data on a pdf page appears twice in private window r=smaug
Pushed by opettay@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e36eb8d0750f
pdf.js modal for unsaved data on a pdf page appears twice in private window r=smaug

https://hg.mozilla.org/mozilla-central/rev/e36eb8d0750f

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox110: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 110 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: