The Add Bookmark/Folder modals are not displayed if the user opened the Bookmarks Toolbar submenu
Categories
(Firefox :: Bookmarks & History, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox-esr78 | --- | unaffected |
| firefox-esr91 | --- | verified |
| firefox90 | --- | unaffected |
| firefox91 | --- | wontfix |
| firefox92 | --- | verified |
| firefox93 | --- | verified |
People
(Reporter: Gabi, Assigned: enndeakin)
References
(Regression)
Details
(Keywords: regression)
Attachments
(2 files)
|
661.30 KB,
image/gif
|
Details | |
|
48 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
RyanVM
:
approval-mozilla-esr91+
|
Details | Review |
2021-08-06_13h50_43.gif
Affected versions
- Fx 92.0a1
- Fx 91.0b9
Affected platforms
- Windows 10 x64
- macOS 10.12.6
- Ubuntu 20
Steps to reproduce
- Launch Firefox
- Right click on a new tab Bookmarks Toolbar
- Open the bookmark toolbar sub-menu (Always Show/Never Show/Only Show on new tab)
- Click on the Add folder option
Expected result
- All the bookmarks toolbar option should work after opening Bookmarks toolbar sub-menu options
Actual result
- Unable to add a bookmark or a folder if the Bookmark toolbar submenu was previously opened
Regression range
*Will provide a regression asap
Additional notes
- See attached
|
Reporter | |
Updated•3 years ago
|
|
|
Reporter | |
Updated•3 years ago
|
|
||
Comment 1•3 years ago
|
||
Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=10caeee69668a67e43707bb2f55c001a167a3aba&tochange=141b15981515d33aedb3c1edd8505956b2494730
|
|
||
Updated•3 years ago
|
|
|
||
Updated•3 years ago
|
|
Assignee | |
Comment 2•3 years ago
|
||
Should only clear the last trigger node when the top-level popup is hidden
|
||
Updated•3 years ago
|
|
||
Updated•3 years ago
|
Pushed by neil@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1a5ce9e3a731 bookmarks commands to add bookmarks and folders not working after a submenu is opened, r=mak
|
||
Comment 4•3 years ago
|
||
| bugherder | ||
|
||
Comment 5•3 years ago
|
||
The patch landed in nightly and beta is affected.
:enndeakin, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.
For more information, please visit auto_nag documentation.
|
|
Assignee | |
Comment 6•3 years ago
|
||
Comment on attachment 9235126 [details]
Bug 1724395, bookmarks commands to add bookmarks and folders not working after a submenu is opened, r=mak
Beta/Release Uplift Approval Request
- User impact if declined: Edit Bookmark/Folder dialog does not appear if a submenu has been opened
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: Yes
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Minor change that caused a regression
- String changes made/needed: None
|
||
Comment 7•3 years ago
|
||
Comment on attachment 9235126 [details]
Bug 1724395, bookmarks commands to add bookmarks and folders not working after a submenu is opened, r=mak
Approved for 92.0b3 and 91.1esr.
|
|
||
Comment 8•3 years ago
|
||
| bugherder uplift | ||
|
|
||
Comment 9•3 years ago
|
||
| bugherder uplift | ||
|
||
Updated•3 years ago
|
|
||
Updated•3 years ago
|
|
|
Reporter | |
Comment 10•3 years ago
|
||
Verified issue as fixed on Fx 92.0b3 and Fx 91.1esr treeherder build with Windows 10x64, Ubuntu 18.4 and macOS 10.12.6
|
|
Reporter | |
Updated•3 years ago
|
|
|
Reporter | |
Updated•3 years ago
|
|
|
Reporter | |
Updated•3 years ago
|
Description
•