Affected versions

• 89.0.2
• 91.0
• 90.0

Affected platforms

• Windows 10x64
• macOS 11
• Ubuntu 18.04

Preconditions

• Download ania locale build and perform an update (e.g 89.0.1 or 90.x).

Steps to reproduce

1. Open the downloaded ia build and go to Help-> About Firefox.

Expected result

• Download progress is displayed and then the restart to update button appears.

Actual result

• Searching for updates or nothing is displayed (88.x) inside the update status field until closing and reopening About Firefox UI. Also this.downloadStatus is null error can be seen inside the browser console.

Regression range

• 85.0.2 is not affected. I will search for one ASAP.

Notes

• Attached a screen recording.
• On 88.0.1 there is nothing displayed inside the update UI (no progress and no restart button) until it is closed and reopened: link.
• Attached console erros ar well: link
• I saw this only on ia locale for now when testing updates to 91.0-build2 on release-localtest.

Adam, does this ring a bell?

I got a regression range between nightly 2021-01-29-16-01-10 (good) and 2021-01-30-19-41-15 (bad), the ia pushlog includes an update here. I suspect that the issue is related to this line which has an <etiquetta> tag instead of <label>, I can't find any other example of that. I don't understand the localization stack well enough to guess why it cause this kind of failure, but it seems likely.

I'll see if I can find anything relevant in the repack logs, I looked at L10n B10 (I think this is where aboutDialog.ftl would get processed for ia?) and L10n-Rpk ia from a recent release build, didn't spot anything but I don't really know what I'm looking for. I don't think we keep taskcluster logs going back to January so I can't compare before and after.

Fixed it :-(
https://hg.mozilla.org/l10n-central/ia/rev/a6bcf11ad294927b1083576b4bc70533f73a4e03

Unfortunately it will only be fixed for 92 at this point.

I guess this makes sense, at runtime fluent will just drop that tag when it sanitizes the translation, so there won't be a downloadStatus element. It seems like there should be a warning about "An element of forbidden type", but maybe that wouldn't show up on the browser console, or maybe it isn't actually related to this fluent-dom codepath at all.

Might be worth picking this up in a dot release if the opportunity arises. Otherwise, we can at least make sure ESR91 picks it up for the 91.1esr release next cycle.

(In reply to Ryan VanderMeulen [:RyanVM] from comment #5)

Might be worth picking this up in a dot release if the opportunity arises. Otherwise, we can at least make sure ESR91 picks it up for the 91.1esr release next cycle.

The number of users for this locale is really small, and this string landed in Firefox 86, so the problem is been there for a while.

But I agree that it would make sense to update ESR91 at some point to improve localization coverage (it will require uplifting l10n-changesets.json). I'd prefer doing that in a couple of cycles though, so that we can pick up more fixes for other locales as well.

Verified fixed while updating from a Nightly after 2021-08-05 ia locale on Windows 10x64, macOS 10.15 and Ubuntu 21.04. The update status is successfully updated inside the About Firefox window and no longer remains stuck.