Ship accent-color
Categories
(Core :: CSS Parsing and Computation, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox92 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
References
(Blocks 1 open bug)
Details
(Keywords: dev-doc-complete)
Attachments
(3 files, 1 obsolete file)
|
Assignee | |
Comment 1•3 years ago
|
||
|
|
Assignee | |
Comment 2•3 years ago
|
||
|
|
Assignee | |
Comment 3•3 years ago
|
||
The accent-color computation right now chooses between black and white,
which is not ideal.
I tried to make it so that authors could choose the foreground colors in
the linked CSSWG issue from the comment, but that didn't go anywhere.
I think choosing a contrasting color that is in-line and contrasting
enough with the accent-color chosen by the page when darkening is better
than just black or white.
If we want the black-or-white behavior we can just change
layout.css.accent-color.target-contrast-ratio to something large enough.
https://accent-color.glitch.me/ is a nice playground to see this patch
in action.
Depends on D120722
|
||
Updated•3 years ago
|
|
|
Assignee | |
Comment 4•3 years ago
|
||
No other property returns currentcolor in the computed style, and
Chrome agrees with us on this test.
|
||
Updated•3 years ago
|
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2a0274aa4014 Fix an accent-color test. r=mstange
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ef0ebe9d47b3 Fix RelativeLuminanceUtils::Adjust to not choke on blacks / zero components. r=mstange https://hg.mozilla.org/integration/autoland/rev/7a7d9a6cc513 Tweak accent-color foreground computation and let it ride the trains. r=mstange
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/29776 for changes under testing/web-platform/tests
|
||
Comment 8•3 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/2a0274aa4014
https://hg.mozilla.org/mozilla-central/rev/ef0ebe9d47b3
https://hg.mozilla.org/mozilla-central/rev/7a7d9a6cc513
Upstream PR merged by moz-wptsync-bot
|
||
Comment 10•3 years ago
|
||
I've updated BCD and release notes: https://github.com/mdn/content/issues/7752
Description
•