Closed Bug 1717819 Opened 3 years ago Closed 3 years ago

Title: About:preferences search result tooltip is wrongly displayed

Categories

(Firefox :: Toolbars and Customization, defect, P3)

Firefox 90
defect

Tracking

()

VERIFIED FIXED
91 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox89 --- unaffected
firefox90 --- wontfix
firefox91 --- verified

People

(Reporter: ccomorasu, Assigned: Gijs)

References

Details

(Keywords: regression)

Attachments

(1 file)

[Affected versions]:

  • Fx 90.0b

[Affected platforms]:

  • Windows 10 x64
  • macOS 10.15
  • Ubuntu 16.04 LTS x86

[Steps to reproduce]:

  1. Launch Firefox, access about:preferences.
  2. Search for a term that can be found inside subdialogs or doorhangers (e.g. "Firefox").
  3. Scroll down to HTTPS-Only Mode.

[Expected result]:

  • The tooltips are placed above, at the middle of a button.

[Actual result]:

  • There is a tooltip displayed, but there is no button present.

[Regression range]:

  • This issue only reproduces on Fx 90.0b builds, I will return with a regression range.

[Additional notes]:

  • Tried this on both a clean and used profile with the same result.
  • The HTTPS-Only Mode is not displayed in nightly, however even after enabling that with dom.security.https_only_mode in about:config, the issue doesn't reproduce on any nightly (I have tried 89 and 90 nightly versions).
  • The first occurrence was found on beta: 90.0b1.
Has Regression Range: --- → no
Has STR: --- → yes

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=5d03a9d6cb8aeba1bb488b989712ad9cfa0546d2&tochange=8347db9863fc1c6dfe8d15fb4eb1426f283a6b53

I can reproduce the issue since the build landed Bug 1662710.
This is not a regression, but an implementation problem.

Blocks: 1662710

Thank you, Alice!

Has Regression Range: no → yes

:ccomorasu, since this bug is a regression, could you fill (if possible) the regressed_by field?
For more information, please visit auto_nag documentation.

Flags: needinfo?(cristian.comorasu)

After further investigation I agree with comment 1. It is an implementation error. Updating the bug accordingly.

Flags: needinfo?(cristian.comorasu)
Keywords: regression

I'm also removing the align=end, because the vbox is adjacent to a flex=1 vbox,
so all horizontal space will be eaten by that other box, meaning alignment of
the button is a no-op as its container is the same width as the button anyway.

Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Priority: -- → P3

(In reply to Cristian Comorasu, QA [:ccomorasu], Release Desktop QA from comment #0)

  1. Search for a term that can be found inside subdialogs or doorhangers (e.g. "Firefox").
  • The HTTPS-Only Mode is not displayed in nightly, however even after enabling that with dom.security.https_only_mode in about:config, the issue doesn't reproduce on any nightly (I have tried 89 and 90 nightly versions).

This is because the brand name of nightly is "Nightly". Searching for "Nightly" allows reproducing the bug on nightly.

Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/01351267a9dd
wrap exception button for https-only mode in hbox so search tooltips align correctly, r=mconley
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
Flags: qe-verify+

Reproduced the issue on Fx 90.0b1 Windows 10 x64.
Issue verified as fixed on Fx 91.0b9 and Fx 92.0a1 Windows 10 x64, Ubuntu 18.4 and macOS 10.12.6

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: