Closed Bug 1714512 Opened 3 years ago Closed 3 years ago

Focus is partially visible on selected items in Autoplay settings

Categories

(Toolkit :: Themes, defect)

defect

Tracking

()

RESOLVED FIXED
91 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox89 --- wontfix
firefox90 --- wontfix
firefox91 --- verified

People

(Reporter: csasca, Assigned: itiel_yn8)

References

(Regression)

Details

(Keywords: regression)

Attachments

(3 files, 1 obsolete file)

Attached image focus.gif

Affected versions

  • Firefox 90.0b3
  • Firefox 91.0a1

Affected platforms

  • Windows 8.1 & Windows 10
  • Ubuntu 20.04

Steps to reproduce

  1. Launch Firefox
  2. Access about:preferences#privacy and click on Settings for Autoplay
  3. Have a website added in the list
  4. Press tab multiple times to focus on Status

Expected result

  • The focus is fully visible on the selected website

Actual result

  • The focus is visible on the selected website only on the lower side of the button

Regression range

  • Will see for a regression

Additional notes

  • The issue can be seen in the attachment
  • The issue may be present in other places like the Autoplay settings as well
  • macOS doesn't seem to be affected as pressing tab, it won't select the status at all
Has Regression Range: --- → no
Has STR: --- → yes
QA Whiteboard: [qa-regression-triage]

Hi,

Here's the regression range found:

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=b1f7bf0f85fdbbd696db257490bc043aea6b3c79&tochange=e1fa9dc7464ba49efdf422116ac2c92e2d40a200

First good build 2021-03-01
First bad build 2021-04-01

Maybe his one was the regressor? https://bugzilla.mozilla.org/show_bug.cgi?id=1698355

Let me know if you need additional information

Best regards,
Clara

Has Regression Range: no → yes

Is bug 1698355 the cause of this?

Component: DOM: UI Events & Focus Handling → Themes
Flags: needinfo?(itiel_yn8)
Product: Core → Toolkit

Very plausible.

Assignee: nobody → itiel_yn8
Status: NEW → ASSIGNED
Flags: needinfo?(itiel_yn8)
Regressed by: 1698355

Also fix the contrast for these menulists.
Also fix some styling in the containers section in about:preferences

Pushed by itiel_yn8@walla.com:
https://hg.mozilla.org/integration/autoland/rev/7f4be4c5eb80
Fix focus rings in menulists inside a richlistitem r=preferences-reviewers,Gijs
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
Attached image focus.JPG

Issue verified and fixed in nightly 91.0a1 (2021-06-30) (64-bit)
Updating flags accordingly.
Best,
Clara

Blocks: 1719359

Comment on attachment 9229767 [details]
Make the fix in Bug 1714512 more consistent

Revision D119102 was moved to bug 1719359. Setting attachment 9229767 [details] to obsolete.

Attachment #9229767 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: