Affected versions

• 90.0a1 (20210525093431)
• 89.0 (20210524222230)

Affected platforms

• Windows 10x64
• macOS 11.4
• Ubuntu 18.04

Steps to reproduce

1. Open Firefox and Pocket menu.
2. Right-click inside the pocket menu and then right-click on the toolbar button.
3. Select Pin to overflow.

Expected result

• Pocket menu is closed and the button is pinned to the overflow menu.

Actual result

• Nothing happens (same for remove from the toolbar)

Regression range

• This is reproducible starting with bug 1693376 so I’m assuming that this is the regressor because Remove from pocket was working while the button was inside the address bar after following the above str.

Notes

• Attached a screen recording.
• This happens on the latest Nightly as well with the fixed context menu for the pocket panel.
• On macOS the pocket panel is closed after step 2 but the issue is still reproducible.
• When using Pin the first time it may be possible to work but after is not working anymore.

I'm not able to reproduce.

But also looking at the gif, it looks like that's a version before bug 1701152, because in the gif I see many items in the context menu.

I also suspect bug 1701152 may have fixed the issue, so this might only be present in 89, and not 90.

Alexandru can you please confirm if the issue can indeed not be reproduced on 90 anymore so this can be triaged accordingly?

I can reproduce the issue with Firefox 90.0b4 (20210606185718) and 91.0a1 (20210606214208) as well.

I can reproduce now, I'll dig in a bit more tomorrow.

I can only reproduce in Windows, I cannot reproduce in Fedora.