User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0

Steps to reproduce:

1. Set Bookmarks Toolbar to Never Show.
2. Bookmark a webpage selecting Bookmarks Toolbar as Folder.

Actual results:

Bookmarks Toolbar pops up at the top.

You don't even need to hit Done. As soon as Bookmarks Toolbar is selected in the Folder dropdown, it pops up.

Expected results:

Bookmarks Toolbar doesn't pop up.

The Bugbug bot thinks this bug should belong to the 'Firefox::Bookmarks & History' component, and is moving the bug to that component. Please revert this change in case you think the bot is wrong.

The issue is reproducible on all versions since Firefox 87 so I'm setting the flags and its status as "NEW"

Thank you for reporting!

I think the toolbar is shown temporarily to show the bookmark destination, as soon as I move to another tab it goes away.
Does the toolbar persist for you?

Oh you're right it doesn't actually persist after leaving the tab haha. My bad. And here I am deactivating it through the context menu every time this happens.

Still though, why have it pop up? You don't do it for any other folder. Not to mention I already know the destination (since I just chose it myself).

yes, I think it's confusing, but I'm not sure if there's a way to distinguish when the user made an explicit choice about the toolbar rather than it being the default hidden state? Gijs, what's the expected outcome we wanted? I think we should not be showing the toolbar temporarily.

(In reply to Marco Bonardo [:mak] from comment #6)

yes, I think it's confusing, but I'm not sure if there's a way to distinguish when the user made an explicit choice about the toolbar rather than it being the default hidden state? Gijs, what's the expected outcome we wanted? I think we should not be showing the toolbar temporarily.

To me this feels like something where we should defer to UX. I don't have a strong opinion. I can definitely see why as a user who is very familiar with how bookmarks work and really doesn't want to see the toolbar, this could be annoying.

OTOH, adding inconsistency by showing the toolbar only the first time or only if you haven't manually chosen the toolbar when the default folder was something else, adds implementation complexity and will probably cause confusion for less-expert users (ie why isn't it showing the toolbar now? But it shows it for the next bookmark (where the default was already the toolbar, because it changed after the previous bookmark being put there)?). Having just triaged bug 1709107 which includes some expert users being confused about not being offered options that make no sense in their situation (manually restoring a session when that already happened automatically), I am not sure that trying to be "clever" here will really fix anything.

No longer showing the toolbar at all removes feedback the first time the user bookmarks, which also doesn't seem great. So, I don't really know that there's a simple solution here...

Jared, do you recall who did the UX work for this so we can ask them?

(In reply to :Gijs (he/him) from comment #7)

OTOH, adding inconsistency by showing the toolbar only the first time or only if you haven't manually chosen the toolbar when the default folder was something else, adds implementation complexity and will probably cause confusion for less-expert users (ie why isn't it showing the toolbar now? But it shows it for the next bookmark (where the default was already the toolbar, because it changed after the previous bookmark being put there)?).

I don't think so.
A less expert user will likely just stick to the initial state anyway, that means if they never add to the toolbar it stays not visible, if they add to it it stays visible (until an explicit choice is made, but less expert users are unlikely to do that).
A more expert user will probably make a choice about the toolbar state, either immediately of after the first time they add to the toolbar and we show it, and that choice should stick.

Here the problem is that the user made a choice and we temporarily break it. This is very confusing.

(In reply to :Gijs (he/him) from comment #7)

Jared, do you recall who did the UX work for this so we can ask them?

Katie was in charge here. I asked her and she said "If someone actively chooses “Never Show” - we should respect that and never show it".

Setting as a P2 because it seems annoying and confusing for the users.
Patches or mentoring are welcome of course.

https://hg.mozilla.org/mozilla-central/rev/572629526eed

I've verified the fix on Firefox 94.0b2