Closed
Bug 1705062
Opened 3 years ago
Closed 3 years ago
Items inside sidebar hard to see with Dark theme enabled in Firefox
Categories
(Firefox :: Theme, defect)
Tracking
()
VERIFIED
FIXED
89 Branch
| Tracking | Status | |
|---|---|---|
| firefox-esr78 | --- | unaffected |
| firefox87 | --- | unaffected |
| firefox88 | --- | unaffected |
| firefox89 | --- | verified |
People
(Reporter: bmaris, Assigned: alexical)
References
(Regression)
Details
(Keywords: regression)
Attachments
(2 files)
Screenshot showing the issue
Affected versions
- Latest Nightly 89.0a1
Affected platforms
- Windows 10
- Ubuntu 18.04
- macOS 11.3
Steps to reproduce
- Launch Firefox
- Change the theme of the Firefox to Dark
- Toggle the Bookmark/History Sidebar
Expected result
- Sidebar respects the Dark theme, having the background dark but the text white so it can be visible.
Actual result
- Background is dark but also is the text of the bookmarks/history.
Regression range
- First bad: dc67a43df7384b22eb61822c0b1b020ad45989cb
- Last good: 5ca21d05036cd0768676001c29b2445c3d7be20a
- Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=5ca21d05036cd0768676001c29b2445c3d7be20a&tochange=dc67a43df7384b22eb61822c0b1b020ad45989cb
- Potential regressor: Bug 1704164 - Dark mode colors set too late in activity stream startup
Additional notes
- Screenshot showing the issue is attached.
Suggested severity
- I would say this should be of a high severity (S2) since this is very visible to users making the items inside sidebar very hard to see
Flags: needinfo?(dothayer)
|
Reporter | |
Comment 1•3 years ago
|
||
|
|
Reporter | |
Updated•3 years ago
|
Has Regression Range: --- → yes
Has STR: --- → yes
|
Assignee | |
Updated•3 years ago
|
Assignee: nobody → dothayer
Status: NEW → ASSIGNED
Flags: needinfo?(dothayer)
|
|
Assignee | |
Comment 2•3 years ago
|
||
It appears for the sidebar document, this.contentWindow.top is null at the time
of DOMContentLoaded. Accordingly we need to wait for pageshow. This patch waits
for pageshow and ensures we don't update twice when pageshow shows up if we
successfully updated on DOMContentLoaded.
Pushed by dothayer@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/24d866128659 Handle pageshow in LightweightThemeChild r=mconley
|
||
Comment 5•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
|
|
Reporter | |
Comment 6•3 years ago
|
||
Verified this is fixed using Firefox 89.0b3 across platforms (Windows 10, macOS 11.2 and Ubuntu 18.04).
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•