Closed Bug 1704508 Opened 3 years ago Closed 3 years ago

Toolbar does not automatically hide

Categories

(Core :: Widget: Cocoa, defect, P2)

Desktop
macOS
defect

Tracking

()

RESOLVED WORKSFORME
Tracking Status
firefox88 --- disabled
firefox89 --- affected

People

(Reporter: csasca, Unassigned)

Details

(Keywords: regression, Whiteboard: [mac:fullscreen:native-affected][mac:fullscreen:nonnative-affected])

Affected versions

  • Firefox 89.0a1 (2021-04-12)

Affected platforms

  • macOS 10.15.7

Steps to reproduce

  1. Launch Firefox
  2. Enter Fullscreen
  3. Right click on toolbar and activate Hide Toolbars option

Expected result

  • The toolbar is hidden automatically

Actual result

  • The toolbar will hide only if the user clicks on the current page viewport

Regression range

  • Will see for a regression

Additional notes

  • The issue can be seen in the following attachment
  • macOS 11.2.3 (arm) is not affected by this, and when activated, the toolbar automatically hides
Has Regression Range: --- → no
Has STR: --- → yes
Whiteboard: [mac:fullscreen]
QA Whiteboard: [qa-regression-triage]

Searched for a regression, and mozregression pinpointed me between 2021-04-04 and 2021-04-05. On 04 the toolbar hides automatically as expected, while on 05 it does not. Couldn't search in depth between those two as mozregression gave me errors for autoland builds.

Here's the pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=ab7decc3020866de71069e01557f9d3c5fe7da59&tochange=65dc61a78542a0521d4c9a42ff7bd152a88029fc

Has Regression Range: no → yes

(In reply to Catalin Sasca, QA [:csasca] from comment #1)

Searched for a regression, and mozregression pinpointed me between 2021-04-04 and 2021-04-05. On 04 the toolbar hides automatically as expected, while on 05 it does not. Couldn't search in depth between those two as mozregression gave me errors for autoland builds.

Here's the pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=ab7decc3020866de71069e01557f9d3c5fe7da59&tochange=65dc61a78542a0521d4c9a42ff7bd152a88029fc

I don't believe this is an accurate "regression" range. I found that this works as expected unless the focus is on the URL bar. I was able to reproduce this same behavior in the supposedly "good" build from 2021-04-04. With this in mind, I found this range when this issue started occurring, which coincides with the landing of bug 740148. The fact that the toolbar doesn't hide when the URL bar is focused is mentioned in bug 740148 comment 101.

Harry, could you weigh in here if we should keep this bug open? Or are you already tracking this somewhere else?

Flags: needinfo?(htwyford)
Priority: -- → P2
Whiteboard: [mac:fullscreen] → [mac:fullscreen:native-affected][mac:fullscreen:nonnative-affected]

I don't think it's an issue that toolbars don't hide when the Urlbar is focused. In that case, the user is interacting with part of the browser chrome, so we wouldn't want to hide it. The two issues mentioned in bug 740148 comment 11 are more specific and are worth tracking. I filed a new bug for those (bug 1710151). We can reopen this in case this 10.15-specific issue ends up being reproducible without the Urlbar focused.

Status: NEW → RESOLVED
Closed: 3 years ago
Flags: needinfo?(htwyford)
Resolution: --- → WORKSFORME
Summary: Hide toolbar option in fullscreen does not automatically hide the toolbar on mac 10.15 → Toolbar does not automatically hide
You need to log in before you can comment on or make changes to this bug.