Closed Bug 1704037 Opened 3 years ago Closed 3 years ago

Nightly blog page - Download Firefox button overlaps banner bellow on certain widths

Categories

(Infrastructure & Operations :: Blogs, defect)

Production
defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: cfogel, Assigned: craigcook)

References

()

Details

Attachments

(1 file)

Attached image image (3).png

Affected versions
*89.0a1(2021-04-07);

Affected platforms

  • Windows 10;
  • will confirm on others as well when possible;

Steps to reproduce

  1. Launch Firefox, access https://blog.nightly.mozilla.org/
  2. Next, you can do any of the 3 triggers, since it's caused by css/@mediaquerries changes:
  • Set the browser to take up half of the screen, reduce width gradually
  • Use RDM to check different smaller resolutions;
  • Zoom in;

Expected result

  • elements are displayed as expected;

Actual result

  • the Download Firefox Nightly button reaches a breakpoint in which it overlaps with the banner bellow on resize;

Additional notes

  • attached screenshot to illustrate the issue.
Group: mozilla-employee-confidential

Adding white-space:nowrap; should fix that:

/* style.css | https://3sgkpvh31s44756j71xlti9b-wpengine.netdna-ssl.com/wp-content/themes/frontierline/style.css?ver=5.6.2 */

.nav-global .nav-global-fxdownload {
  white-space: nowrap;
}

Happy to make a PR for this patch but I don't remember where the code is.

Summary: Nightly blog page - Download Firefox button → Nightly blog page - Download Firefox button overlaps banner bellow on certain widths

Craig, did we file the bug in the right component for this CSS issue? I can probably make a PR to the theme but don't remember the repository location. Thanks.

Flags: needinfo?(craigcook.bugz)

I'm on it.

Assignee: nobody → craigcook.bugz
Flags: needinfo?(craigcook.bugz)
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED

Looks good, thanks!

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: