Closed Bug 1704027 Opened 3 years ago Closed 3 years ago

about:profiling - Checkboxes no longer centered with strings on row

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect, P2)

Firefox 89
defect

Tracking

(firefox-esr78 unaffected, firefox87 unaffected, firefox88 unaffected, firefox89 verified)

VERIFIED FIXED
89 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox87 --- unaffected
firefox88 --- unaffected
firefox89 --- verified

People

(Reporter: cfogel, Assigned: itiel_yn8)

References

(Blocks 1 open bug, )

Details

(Keywords: regression, Whiteboard: [proton-aboutpages] [priority:2b])

Attachments

(2 files)

Attached image checkboxxx.png

Affected versions

  • 89.0a1(2021-04-07);

Affected platforms

  • Win10, Ubuntu 18.04
  • will check on other OSs when possible;

Steps to reproduce

  1. Launch Firefox, access about:profiling
  2. Scroll down, look at items;

Expected result

  • radiobuttons and checkboxes are centered with the row name (not description bellow)

Actual result

  • checkboxes are not centered nicely;
  • from the Threads section are ok, rest are not;

Regression range

  • First bad: 2021-04-07;
  • Last good: 2021-04-06;
  • Pushlog: URL

Additional notes

  • attached screenshot to illustrate the issue.
Has Regression Range: --- → yes
Has STR: --- → yes
Flags: needinfo?(rtestard)
Flags: needinfo?(rtestard)
Priority: -- → P2
Whiteboard: [proton-aboutpages] → [proton-aboutpages] [priority:2b]
OS: Unspecified → All
Hardware: Unspecified → All
Assignee: nobody → itiel_yn8
Status: NEW → ASSIGNED
Attachment #9214683 - Attachment description: Bug 1704027 - Switch to using grid for checkboxes and radiobuttons containers in about:profiling to fix alignment of input and text r?julienw → Bug 1704027 - Switch to using grid for checkboxes and radiobuttons containers in about:profiling to fix alignment of input and text r?julienw!,mconley!
Pushed by itiel_yn8@walla.com:
https://hg.mozilla.org/integration/autoland/rev/667202e3a44d
Switch to using grid for checkboxes and radiobuttons containers in about:profiling to fix alignment of input and text r=julienw,mconley
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
Flags: qe-verify+

Reproduced the initial issue using old Nightly from 2021-04-08, verified that the checkboxes inside about:profiling are now centered with the option strings using 89.0b4 across platforms (Windows 10, Ubuntu 18.04 and macOS 11.3).

Status: RESOLVED → VERIFIED
Flags: qe-verify+
Regressions: 1707589
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: